Bug#748465: Renaming repacked tarball (was Re: Excluded-Files feature reimplemented)

[David Prévot]

Hi,

On Wed, May 21, 2014 at 09:07:25AM +0200, Joachim Breitner wrote:
> Am Mittwoch, den 21.05.2014, 08:59 +0200 schrieb Andreas Tille:
> > On Tue, May 20, 2014 at 09:25:32PM -0400, James McCoy wrote:
> > > Given the above, how about a “--repack-suffix …” that gets passed
> > > through to mk-origtargz?  So “uscan … --repack-suffix +dfsg1” or a
> > > similar mk-origtargz invocation repacks and adds +dfsg1 to the upstream
> > > version.
> > > 
> > > This could possibly be exposed by a new opts value in the watch file
> > > itself -- opts=repacksuffix=+dfsg1
> > 
> > Both options (--repack-suffix to uscan (non-exclusive) or
> > opts=repacksuffix=+dfsg1 are perfectly fine for me since I like it
> > more than the "default mangling".
> 
> no opinion here, but a technical point: It wouldn’t be a mk-origtargz
> option. mk-origtargz gets the version number either from “--version” (so
> the caller can put it there already) or from debian/changelog (where the
> suffix should also be included). mk-origtargz has no notion of “version
> number as declared by upstream”, and hence the option needs to be
> implemented in uscan.

Since one can already use opts=uversionmangle=s/$/+dfsg/ in d/watch,
maybe there is nothing to fix at all, except perhaps documenting it. The
behaviour change can be considered a bug in the initial implementation
now fixed, so this bug can be closed without further action if that’s
the case.

Regards

David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20140521/802bf814/attachment.sig>