Bug#749729: [sadt] please skip non-executable tests

[Jakub Wilk]

Hi James,

Thanks for prodding me. I've been procrastinating for far too long.

* James McCoy <jamessan at debian.org>, 2014-10-09, 22:09:
>>>I suggest that sadt skips non executable tests with a warning and 
>>>documents this behaviour (as it does with missing dependencies), or 
>>>displays a warning when modifying the permissions. It took me some 
>>>time to find who was interfering with my version control system.
>>
>>Thanks, that's a pretty strong argument that chmod'ing tests is not a 
>>good idea, at least not by default.
>
>Do you intend to make some changes for this soon?

I've attached a patch for skipping non-executable tests instead of 
chmod+x'ing them. But now I'm a bit hesitant that this is the right 
thing to do...

I think it would be more user-friendly if sadt did this:

* If sadt have to make copy of the source tree anyway (i.e., one of the 
tests declares the rw-build-tree restriction), then fix permissions in 
the copy.

* Otherwise, try chmod+x'ing the test file in the source tree, and if 
that fails, skip the test.

* Restore the original permissions afterwards.

Does it sound sane?

-- 
Jakub Wilk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 749729.diff
Type: text/x-diff
Size: 1764 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20141011/0adbf645/attachment.diff>