Bug#749729: [sadt] please skip non-executable tests
Jakub Wilk
jwilk at debian.org
Wed Oct 22 19:26:08 UTC 2014
* James McCoy <jamessan at debian.org>, 2014-10-11, 22:35:
>>I think it would be more user-friendly if sadt did this:
>>
>>* If sadt have to make copy of the source tree anyway (i.e., one of
>>the tests declares the rw-build-tree restriction), then fix
>>permissions in the copy.
Now I noticed that support for rw-build-tree has been broken all the
time. Ooops.
>>* Otherwise, try chmod+x'ing the test file in the source tree, and if
>>that fails, skip the test.
>>
>>* Restore the original permissions afterwards.
>>
>>Does it sound sane?
>
>Sounds good to me.
I've attached patches fixing rw-build-tree and #749729 itself.
--
Jakub Wilk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sadt-fix-rw-build-tree.diff
Type: text/x-diff
Size: 450 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20141022/5af88966/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sadt-restore-permissions.diff
Type: text/x-diff
Size: 1489 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20141022/5af88966/attachment-0001.diff>
More information about the devscripts-devel
mailing list