[devscripts] 02/03: tagpending: Fix ‘uninitialized value in split’

James McCoy jamessan at debian.org
Sat Aug 15 01:56:39 UTC 2015


This is an automated email from the git hooks/post-receive script.

jamessan pushed a commit to branch master
in repository devscripts.

commit bebf6f544bfe3db779d124e12e40f18e328fc3f6
Author: James McCoy <jamessan at debian.org>
Date:   Fri Aug 14 19:43:26 2015 -0400

    tagpending: Fix ‘uninitialized value in split’
    
    If the changelog doesn't contain any Closes, then there's nothing to
    split.
    
    Regression introduced in 7c250fa9d0b31aad0a3ad53d2aeb33ee140dd6dc
    
    Closes: #795470
    Signed-off-by: James McCoy <jamessan at debian.org>
---
 debian/changelog      | 3 +++
 scripts/tagpending.pl | 5 ++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 7a15090..0638dee 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -9,6 +9,9 @@ devscripts (2.15.9) UNRELEASED; urgency=medium
   [ James McCoy ]
   * bts:
     + Add reference to pts-subscribe(1) in bts(1).  (Closes: #794689)
+  * tagpending:
+    + Fix warning when there are no fixed bugs in the changelog.  (Closes:
+      #795470)
 
  -- Joachim Breitner <nomeata at debian.org>  Tue, 11 Aug 2015 21:12:03 +0200
 
diff --git a/scripts/tagpending.pl b/scripts/tagpending.pl
index fde1a04..89897e3 100755
--- a/scripts/tagpending.pl
+++ b/scripts/tagpending.pl
@@ -155,7 +155,10 @@ if (! -f 'debian/changelog') {
 
 my $changelog = changelog_parse(%opt_to);
 my $source = $changelog->{Source};
-my @closes = split ' ', $changelog->{Closes};
+my @closes;
+if ($changelog->{Closes}) {
+    @closes = split ' ', $changelog->{Closes};
+}
 my @lines = split /\n/, $changelog->{Changes};
 my $header = $lines[1];
 my $changes = join "\n", grep /^ {3}[^[]/, @lines;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/collab-maint/devscripts.git



More information about the devscripts-devel mailing list