Bug#776318: devscripts: [mk-origtargz] creates string with duplicate entries of files to exclude

[Andreas Tille]

reopen 776318
thanks

Hi James,

I insist that the latest change in uscan / mk-origtargz is a step
backwards since it results in errors when not needed and moreover no
exxor occured in previous versions (namely 2.14.10 which I tested
without any problem).  I have a new occurance of this problem in

   Vcs-Git: git://anonscm.debian.org/debian-med/trinityrnaseq.git

d/copyright says:

Files-Excluded: trinity-plugins/jellyfish-*.tar.gz
 util/support_scripts/ExitTester.jar
 Butterfly/src/lib/*.jar
 Butterfly/*.jar
 Butterfly/prev_vers
 trinity-plugins/rsem*.tar.gz
 trinity-plugins/Trimmomatic*


$ LC_ALL=C mk-origtargz ../trinityrnaseq-2.0.3.tar.gz 
tar: trinityrnaseq-2.0.3/Butterfly/src/lib/jung-graph-impl-2.0.1.jar: Not found in archive
tar: trinityrnaseq-2.0.3/Butterfly/src/lib/jung-api-2.0.1.jar: Not found in archive
tar: trinityrnaseq-2.0.3/Butterfly/src/lib/jung-algorithms-2.0.1.jar: Not found in archive
tar: trinityrnaseq-2.0.3/Butterfly/src/lib/java-getopt-1.0.13.jar: Not found in archive
tar: trinityrnaseq-2.0.3/Butterfly/src/lib/collections-generic-4.01.jar: Not found in archive
tar: trinityrnaseq-2.0.3/Butterfly/src/lib/Jaligner.jar: Not found in archive
tar: trinityrnaseq-2.0.3/Butterfly/prev_vers/Butterfly_r2013_08_14.jar: Not found in archive
tar: Exiting with failure status due to previous errors
mk-origtargz: error: tar --delete --file ../trinityrnaseq_2.0.3+dfsg.orig.tar trinityrnaseq-2.0.3/util/support_scripts/ExitTester.jar trinityrnaseq-2.0.3/trinity-plugins/rsem-1.2.19.tar.gz trinityrnaseq-2.0.3/trinity-plugins/jellyfish-2.1.4.tar.gz trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/trimmomatic.jar trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/trimmomatic-0.32.jar trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/adapters/TruSeq3-SE.fa trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/adapters/TruSeq3-PE.fa trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/adapters/TruSeq3-PE-2.fa trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/adapters/TruSeq2-SE.fa trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/adapters/TruSeq2-PE.fa trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/adapters/NexteraPE-PE.fa trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/adapters/ trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/LICENSE trinityrnaseq-2.0.3/trinity-plugins/Trimmomatic-0.32/ trinityrnaseq-2.0.3/Butterfly/src/lib/jung-graph-impl-2.0.1.jar trinityrnaseq-2.0.3/Butterfly/src/lib/jung-graph-impl-2.0.1.jar trinityrnaseq-2.0.3/Butterfly/src/lib/jung-api-2.0.1.jar trinityrnaseq-2.0.3/Butterfly/src/lib/jung-api-2.0.1.jar trinityrnaseq-2.0.3/Butterfly/src/lib/jung-algorithms-2.0.1.jar trinityrnaseq-2.0.3/Butterfly/src/lib/jung-algorithms-2.0.1.jar trinityrnaseq-2.0.3/Butterfly/src/lib/java-getopt-1.0.13.jar trinityrnaseq-2.0.3/Butterfly/src/lib/java-getopt-1.0.13.jar trinityrnaseq-2.0.3/Butterfly/src/lib/collections-generic-4.01.jar trinityrnaseq-2.0.3/Butterfly/src/lib/collections-generic-4.01.jar trinityrnaseq-2.0.3/Butterfly/src/lib/Jaligner.jar trinityrnaseq-2.0.3/Butterfly/src/lib/Jaligner.jar trinityrnaseq-2.0.3/Butterfly/prev_vers/Butterfly_r2013_08_14.jar trinityrnaseq-2.0.3/Butterfly/prev_vers/Butterfly_r2013_08_14.jar trinityrnaseq-2.0.3/Butterfly/prev_vers/ trinityrnaseq-2.0.3/Butterfly/Butterfly.jar gave error exit status 2


Please make sure that the `tar --delete` command does not get any
duplicated string even if for whatever strange reason two regexps
might match (even if I personally do not think they do after the
original specification.

Kind regards

       Andreas.


On Mon, Jan 26, 2015 at 09:29:44PM +0100, Andreas Tille wrote:
> thanks for your quick reply.
> 
> > They're mentioned twice because the Files-Excluded field in d/copyright
> > lists them twice:
> > 
> > 	Files-Excluded:
> > 	    */System/*/*.js
> > 	    */System/*/*/*.js
> > 
> > The * in a Files (and therefore Files-Excluded) field in d/copyright
> > is recursive:
> > 
> >      * Only the wildcards * and ? apply; the former matches any number of
> >        characters (including none), the latter a single character. Both match
> >        slashs (/) and leading dots, unlike shell globs.
> 
> Hmmm, aren't Files-Excluded shell globs?  At least I consider it the
> outcome of the discussion (and thus I created the expression above which
> worked at least until Fri, 10 Oct 2014 14:01:12 +0200 (latest changelog
> entry).
> 
> > The pattern *.in
> >        therefore matches any file whose name ends in .in anywhere in the
> >        source tree, not just at the top level.
> 
> While I could cope with this change I wonder whether it would not be
> more safe in any case if
> 
>    Files-Excluded: a.x b.x a.x
> 
> would simply remove files a.x and b.x instead of creating an error.  A
> warning would be fine, thought.
> 
> I can confirm that mk-origtargz works nicely after removing
>       */System/*/*/*.js
> so it behaves in fact as you described.
> 
> Kind regards
> 
>        Andreas.
> 
> -- 
> http://fam-tille.de

-- 
http://fam-tille.de