Bug#776318: devscripts: [mk-origtargz] creates string with duplicate entries of files to exclude

[James McCoy]

On Fri, Feb 13, 2015 at 01:51:48PM +0100, Andreas Tille wrote:
> I insist that the latest change in uscan / mk-origtargz is a step
> backwards since it results in errors when not needed and moreover no
> exxor occured in previous versions (namely 2.14.10 which I tested
> without any problem).  I have a new occurance of this problem in
> 
>    Vcs-Git: git://anonscm.debian.org/debian-med/trinityrnaseq.git
> 
> d/copyright says:
> 
> Files-Excluded: trinity-plugins/jellyfish-*.tar.gz
>  util/support_scripts/ExitTester.jar
>  Butterfly/src/lib/*.jar
>  Butterfly/*.jar
>  Butterfly/prev_vers
>  trinity-plugins/rsem*.tar.gz
>  trinity-plugins/Trimmomatic*

This listing should be fixed.  However, I see that the reason it used to
"work" is that adding support for warning about unmatched patterns
caused files to be added to the "to delete" list multiple times when
there are multiple patterns which match.

I'll make an adjustment to that.

> Please make sure that the `tar --delete` command does not get any
> duplicated string even if for whatever strange reason two regexps
> might match (even if I personally do not think they do after the
> original specification.

If by "original specification" you mean handling Files-Excluded like
shell globs, then that was flawed to start with.  There's no reason to
treat Files-Excluded differently from Files.

Cheers,
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan at debian.org>