Bug#788611: devscripts: [dget] dget exits 0 when failing to download

[Lars Wirzenius]

Package: devscripts
Version: 2.15.3
Severity: normal
Tags: upstream

Dear Maintainer,

When I run the following command:

    dget -du http://xxxxxx

I get the dget usage message, and the command exits with 0. It should
exit with non-zero instead, as it failed to do anything useful. The
exit 0 in this case makes it a little harder to use dget
programmatically, as for example in a CI system.

Complete output:

    liw at exolobe1$ dget -du http://xxxxxx
    Usage: dget [options] URL ...
           dget [options] [--all] package[=version] ...

    Downloads Debian packages (source and binary) from the specified URLs (first form),
    or using the mirror configured in /etc/apt/sources.list(.d) (second form).
    It is capable of downloading several packages at once.

       -a, --all       Package is a source package; download all binary packages
       -b, --backup    Move files that would be overwritten to ./backup
       -q, --quiet     Suppress wget/curl output
       -d, --download-only
                       Do not extract downloaded source
       -x, --extract   Unpack downloaded source (default)
       -u, --allow-unauthenticated
                       Do no attempt to verify source package signature
       --build         Build package with dpkg-buildpackage after download
       --path DIR      Check these directories in addition to the apt archive;
                       if DIR='' then clear current list (may be used multiple
                       times)
       --insecure      Do not check SSL certificates when downloading
       --no-cache      Disable server-side HTTP cache
       --no-conf       Don't read devscripts config files;
                       must be the first option given
       -h, --help      This message
       -V, --version   Version information

    Default settings modified by devscripts configuration files:
      (none)
    liw at exolobe1$ echo $?
    0
    liw at exolobe1$ 
    

-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
DEBSIGN_KEYID=5E8511F9 
DSCVERIFY_KEYRINGS=/home/liw/.gnupg/pubring.gpg

-- System Information:
Debian Release: 8.0
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages devscripts depends on:
ii  dpkg-dev     1.17.25
ii  libc6        2.19-18
ii  perl         5.20.2-3
ii  python3      3.4.2-2
pn  python3:any  <none>

Versions of packages devscripts recommends:
ii  at                          3.1.16-1
ii  curl                        7.38.0-4+deb8u2
ii  dctrl-tools                 2.23
ii  debian-keyring              2015.04.10
ii  dput                        0.9.6.4
ii  equivs                      2.0.9
ii  fakeroot                    1.20.2-1
ii  file                        1:5.22+15-2
ii  gnupg                       1.4.18-7
ii  libdistro-info-perl         0.14
ii  libencode-locale-perl       1.03-1
ii  libjson-perl                2.61-1
ii  liblwp-protocol-https-perl  6.06-2
ii  libparse-debcontrol-perl    2.005-4
ii  libsoap-lite-perl           1.11-1
ii  liburi-perl                 1.64-1
ii  libwww-perl                 6.08-1
ii  lintian                     2.5.30+deb8u4
ii  man-db                      2.7.0.2-5
ii  patch                       2.7.5-1
ii  patchutils                  0.3.3-1
ii  python3-debian              0.1.27
ii  python3-magic               1:5.22+15-2
ii  sensible-utils              0.0.9
ii  strace                      4.9-2
ii  unzip                       6.0-16
ii  wdiff                       1.2.2-1
ii  wget                        1.16-1
ii  xz-utils                    5.1.1alpha+20120614-2+b3

Versions of packages devscripts suggests:
ii  bsd-mailx [mailx]            8.1.2-0.20141216cvs-2
ii  build-essential              11.7
pn  cvs-buildpackage             <none>
pn  debbindiff                   <none>
pn  devscripts-el                <none>
pn  gnuplot                      <none>
ii  gpgv                         1.4.18-7
ii  libauthen-sasl-perl          2.1600-1
ii  libfile-desktopentry-perl    0.07-1
ii  libnet-smtp-ssl-perl         1.01-3
pn  libterm-size-perl            <none>
ii  libtimedate-perl             2.3000-2
pn  libyaml-syck-perl            <none>
ii  mailutils [mailx]            1:2.99.98-2
ii  mutt                         1.5.23-3
ii  openssh-client [ssh-client]  1:6.7p1-5
pn  svn-buildpackage             <none>
ii  w3m                          0.5.3-19

-- no debconf information