Bug#789074: Regression: licensecheck fails to parse copyright if a / is contained

James McCoy jamessan at debian.org
Thu Jun 18 19:25:25 UTC 2015


On Thu, Jun 18, 2015 at 3:00 AM, Dominique Dumont <dod at debian.org> wrote:
> On Wednesday 17 June 2015 16:58:40 Didier Roche wrote:
>> If we revert that one, with devscript 2.15.5, I can get the digia
>> copyright back:
>>    [Copyright: 2014 Digia Plc and/or its subsidiary(-ies)]
>>
>> I'm unsure about that change (and the other optimizations related into
>> that commit), so I'm not proposing reverting that one right away.
>
> The idea behind this commit was to let Perl compile once the regexp and then
> apply them on all incoming files.

The problematic commit is actually f117e093b, but reverting that
breaks the cddl test.

>> I guess we can introduce one test for that use case.
>
> Sure. Given the complexity of parsing free forms license statements,
> licensecheck should have way more test cases.

$ cat license.txt
// Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
$ licensecheck --copyright license.txt
license.txt: *No copyright* UNKNOWN

Cheers,
-- 
James



More information about the devscripts-devel mailing list