[devscripts] 01/01: Add STARTTLS support without certificate validity verification.

[James McCoy]

Thanks for taking a look at this.

On Mon, Nov 02, 2015 at 09:05:23PM +0000, Andrew Shadura wrote:
> commit 6469c52e8b694622607478475e7cfc67f1ec6a95
> Author: Andrew Shadura <andrewsh at debian.org>
> Date:   Mon Nov 2 21:21:02 2015 +0100
> 
>     Add STARTTLS support without certificate validity verification.

Why isn't certificate validation being done?

>     Use Net::SMTPS for both SMTP+SSL and SMTP+STARTTLS.
>     When not connecting over SSL, always use Net::SMTPS in hope
>     it does STARTTLS when it's detected. If Net::SMTPS isn't
>     available, fall back to plain old Net::SMTP.
>     
>     Replace libnet-smtp-ssl-perl dependency with libnet-smtps-perl
>     dependency promoted to Recommends from Suggests.

Why the change to Recommends?

> diff --git a/scripts/bts.pl b/scripts/bts.pl
> index 55bb83a..6876ab8 100755
> --- a/scripts/bts.pl
> +++ b/scripts/bts.pl
> @@ -98,21 +98,22 @@ sub have_lwp() {
>      return $lwp_broken ? 0 : 1;
>  }
>  
> -sub have_smtp_ssl() {
> -    return ($smtp_ssl_broken ? 0 : 1) if defined $smtp_ssl_broken;
> +sub have_smtps() {
> +    return ($smtps_broken ? 0 : 1) if defined $smtps_broken;
>      eval {
> -	require Net::SMTP::SSL;
> +	require Net::SMTPS;
> +	use IO::Socket::SSL;

This should be a require, otherwise it will happen at compile time, not
runtime.

Cheers,
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan at debian.org>