[devscripts] 03/06: uscan: @PACKAGE@ etc.

[Mattia Rizzolo]

On Tue, Nov 10, 2015 at 04:40:24PM +0000, Osamu Aoki wrote:
>     uscan: @PACKAGE@ etc.
>     
>     Fix #517637 auto-generalise the search regex
>     Fix #539780 Provide a $package variable to uscan environment

one word:  COOL!
:)
really!

but..

> +	# Handle @PACKAGE@ @ANY_VERSION@ @ARCHIVE_EXT@ substitutions
> +	my $any_version = '[-_](\d[\-+\.:\~\da-zA-Z]*)';
> +	my $archive_ext = '(?i)\.(?:tar\.xz|tar\.bz2|tar\.gz|zip)';
> +	my $signature_ext = $archive_ext . '\.(?:asc|pgp|gpg|sig)';

from https://wiki.debian.org/debian/watch#Common_mistakes I think it
would be better to

$archive_ext = '\.(?:zip|tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz)))'

or, to take into account the other bug about ordering,

$archive_ext = '\.(?:(?:tar\.(?:xz|bz2|gz)|txz|tbz|tgz|zip))'

which is the exact reverse, if I typed correctly.


Then, do you think you can do something similar to avoid hardcoding
    opts=uversionmangle=s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha)\d*)$/$1~$2/
and
    opts=dversionmangle=s/\+(debian|dfsg|ds|deb)(\.\d+)?$//
everywhere too?  (always coming from that page)
-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20151110/d1131579/attachment.sig>