Bug#499886: patch

James McCoy jamessan at debian.org
Sun Nov 15 14:59:30 UTC 2015


On Sat, Nov 14, 2015 at 03:49:05PM +0000, Nicholas Bamber wrote:
> It's ready. It does add two bits of functionality to bts to facilitate
> things. There are a few things that could work better. Anything with a ":" I
> have ignored for now but they are the somewhat more obscure options.

Looks good.  Just a minor nitpick below.

> diff --git a/scripts/bts.pl b/scripts/bts.pl
> index 55bb83a..c1d7da7 100755
> --- a/scripts/bts.pl
> +++ b/scripts/bts.pl
> @@ -335,6 +335,10 @@ to use B<mutt> to send emails.
>  
>  Don't use B<mutt> for sending of mails.
>  
> +=item B<--soap-timeout=>I<SECONDS>
> +
> +Specify a timeout for SOAP calls as used by the B<select> and B<status> commands.
> +
>  =item B<--smtp-host=>I<SMTPHOST>
>  
>  Specify an SMTP host.  If given, B<bts> will send mail by talking directly to
> @@ -582,6 +586,7 @@ my ($opt_cachemode, $opt_mailreader, $opt_sendmail, $opt_smtphost);
>  my ($opt_smtpuser, $opt_smtppass, $opt_smtphelo);
>  my $opt_cachedelay=5;
>  my $opt_mutt;
> +my $opt_soap_timeout;
>  my $mboxmode = 0;
>  my $quiet=0;
>  my $opt_ccemail = "";
> @@ -620,6 +625,7 @@ GetOptions("help|h" => \$opt_help,
>  	   "toolname=s" => \$toolname,
>  	   "bts-server=s" => \$btsserver,
>  	   "mutt!" => \$opt_mutt,
> +       "soap-timeout:i" => \$opt_soap_timeout,

The indentation is off here.  There should be a leading tab followed by
aligning spaces.

Cheers,
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan at debian.org>



More information about the devscripts-devel mailing list