Bug#798175: uupdate: fails if upstream version is 0

Osamu Aoki osamu at debian.org
Mon Sep 7 12:55:15 UTC 2015


On Sun, Sep 06, 2015 at 02:13:09PM -0400, James McCoy wrote:
> On Sun, Sep 06, 2015 at 08:34:12PM +0900, Osamu Aoki wrote:
> > So we should ignore return code with 
> >  || true
> 
> That's not necessary, since we aren't using the return value for
> anything.

Yes with #!/bin/bash .

I was wondering why we do not enable "#!/bin/bash -e" for this script.
(Not just within eval $()

Anyway, adding this needs serious code reading... maybe not now for me.
But making code as safe under -e is good idea.  That is the thought
behind this || true to kill the error exit locally for the line.

> > and use
> >  test -z "$UVERSION"
> > to decide if it is a native Debian package or not.
> 
> Ack.
> 
> Feel free to commit it.

Thanks.

Osamu



More information about the devscripts-devel mailing list