[devscripts] 03/04: uupdate: work around missing debian.tar.xz etc.
Osamu Aoki
osamu at debian.org
Sun Sep 13 06:49:00 UTC 2015
On Sat, Sep 12, 2015 at 02:55:45PM -0400, James McCoy wrote:
> On Sat, Sep 12, 2015 at 04:03:38PM +0000, Osamu Aoki wrote:
...
> This would have been better as part of the previous commit, so all the
> --verbose changes were self-contained.
Excuse me.
> > @@ -237,12 +241,26 @@ mustsetvar VERSION "`dpkg-parsechangelog -SVersion`" "source version"
> > # Get epoch and upstream version
> > eval `echo "$VERSION" | perl -ne '/^(?:(\d+):)?(.*)/; print "SVERSION=$2\nEPOCH=$1\n";'`
> >
> > -UVERSION=`expr "$SVERSION" : '\(.*\)-[0-9a-zA-Z.+~]*$'`
> > +if [ -n "$UUPDATE_VERBOSE" ]; then
> > + echo "PATCH = \"$PATCH\" is the name of the patch file" >&2
> > + echo "ARCHIVE = \"$ARCHIVE\" is the name of the next tarball" >&2
> > + echo "NEW_VERSION = \"$NEW_VERSION\" is the next pristine tarball version (oversionmangled)" >&2
> uversionmangled? -----^
This is a leak from the local future trial commit. This needs to be
fixed.
This is the suffix adjusted <origver> for
foo_<origversion>-<rev>.orig.tar.gz obtained from uversionmangled
version.
...
> > @@ -723,6 +741,24 @@ else
> > DIFF="../${PACKAGE}_$SVERSION.debian.tar.xz"
> > DIFFTYPE=tar
> > DIFFUNPACK="tar --xz -xf"
> > + else
> > + # non-native package with $SVERSION in <version>-<revision> format
> > + # missing diff.gz/debian.tar.xz, make it with $OPWD/debian/*
> > + # force to update next version to 3.0 (quilt)
>
> Why force it to 3.0 (quilt) when we don't have a known previous source
> package format to update from? If we don't know what the maintainer is
> using, I'm not sure we should just arbitrarily choose a format for them.
>
> Stopping with an message that we don't know how to proceed seems better
> to me.
OK. Let's limit this to "3.0 (quilt)". For other case, print some
message.
Osamu
More information about the devscripts-devel
mailing list