Bug#847168: devscripts: debuild fails when lintian fails, regression since 2.16.9

[Raphaël Hertzog]

Package: devscripts
Version: 2.16.11
Severity: important

Since debuild now relies on dpkg-buildpackage's hook to run lintian,
a failing lintian fails the whole build process. This was not the case
before 2.16.9. So this is either a regression or a annoying new feature.

When I work on Kali packages, I almost always get a lintian error because
lintian doesn't know of the suite or because my name does not appear in
the maintainer field. I want to be informed of the errors but I don't
want the whole build process to be stopped... I want "gbp buildpackage" to
create my tag and I want debuild to sign my package.

If you consider this a new feature, then I ask you to document how to
configure debuild to not fail on lintian failures (possibly adding a new
option to ignore the result of the check-command).

If you consider this a regression, then the default check hook should have
some "|| true" added at the end or something like that (or you can also
add a new option to ignore the result and have its default to true instead
of false).

Thank you!

-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
DEBRELEASE_UPLOADER=dput
DEBRELEASE_DEBS_DIR=../build-area
DEBCHANGE_RELEASE_HEURISTIC=changelog
DEBCHANGE_MULTIMAINT_MERGE=yes
DEBCHANGE_PRESERVE=yes
DEBUILD_LINTIAN_OPTS="--color always -I"
DEBSIGN_KEYID=0xF2AC729A
DEBSIGN_PROGRAM=gpg2
DEBCHANGE_AUTO_NMU=no

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages devscripts depends on:
ii  dpkg-dev     1.18.15
ii  libc6        2.24-8
ii  perl         5.24.1~rc4-1
pn  python3:any  <none>

Versions of packages devscripts recommends:
ii  apt                         1.4~beta1
ii  at                          3.1.20-1
ii  curl                        7.51.0-1
ii  dctrl-tools                 2.24-2
ii  debian-keyring              2016.09.04
ii  dput                        0.11.0
ii  equivs                      2.0.9+nmu1
ii  fakeroot                    1.21-3
ii  file                        1:5.29-1
ii  gnupg                       2.1.16-2
ii  gnupg2                      2.1.16-2
ii  libdistro-info-perl         0.14
ii  libencode-locale-perl       1.05-1
ii  liblwp-protocol-https-perl  6.06-2
ii  libsoap-lite-perl           1.20-1
ii  liburi-perl                 1.71-1
ii  libwww-perl                 6.15-1
ii  licensecheck                3.0.28-1
ii  lintian                     2.5.49
ii  man-db                      2.7.5-2
ii  patch                       2.7.5-1
ii  patchutils                  0.3.4-2
ii  python3-debian              0.1.29
ii  python3-magic               1:5.29-1
ii  sensible-utils              0.0.9
ii  strace                      4.13-0.1
ii  unzip                       6.0-20
ii  wdiff                       1.2.2-1+b1
ii  wget                        1.18-4
ii  xz-utils                    5.2.2-1.2

Versions of packages devscripts suggests:
ii  adequate                     0.15.1
ii  autopkgtest                  4.2.2
pn  bls-standalone               <none>
pn  bsd-mailx | mailx            <none>
ii  build-essential              12.2
pn  check-all-the-things         <none>
pn  cvs-buildpackage             <none>
pn  devscripts-el                <none>
pn  diffoscope                   <none>
pn  disorderfs                   <none>
pn  dose-extra                   <none>
pn  duck                         <none>
pn  faketime                     <none>
pn  gnuplot                      <none>
ii  gpgv                         2.1.16-2
pn  how-can-i-help               <none>
ii  libauthen-sasl-perl          2.1600-1
ii  libfile-desktopentry-perl    0.22-1
pn  libnet-smtps-perl            <none>
pn  libterm-size-perl            <none>
ii  libtimedate-perl             2.3000-2
pn  libyaml-syck-perl            <none>
pn  mozilla-devscripts           <none>
ii  mutt                         1.7.1-5
ii  openssh-client [ssh-client]  1:7.3p1-5
ii  piuparts                     0.72
pn  ratt                         <none>
pn  reprotest                    <none>
ii  svn-buildpackage             0.8.6
ii  w3m                          0.5.3-33

-- no debconf information