Bug#846711: git-build-recipe: FTBFS: Tests failures

[James McCoy]

On Tue, Dec 06, 2016 at 10:39:44AM +0000, Colin Watson wrote:
> […]
>   subprocess.CalledProcessError: Command '['/usr/bin/debuild', '--tgz-check', '-i', '-I', '-S', '-uc', '-us']' returned non-zero exit status 29
>   }}}
>   
>   stdout: {{{
>   dpkg-buildpackage -rfakeroot -us -uc -i -I -S --check-command=lintian
>   dpkg-buildpackage: error: check-commmand 'lintian' not found
>   }}}
> […]
> 
> git-build-recipe doesn't do anything particular to ask debuild to run
> lintian here, and it doesn't expect or require a lintian check.  It used
> to be that debuild would check whether lintian was in fact installed,
> and not run it if it wasn't; indeed, its documentation still says "then
> runs lintian on the .changes file created (assuming that lintian is
> installed)", thereby claiming that that's still what it does.  But this
> was broken in devscripts 58eb4a4a5e006bf9a2589da0ef2f36aa0d81ed8c when
> changing debuild to use dpkg-buildpackage --check-command.

Indeed.  In order to fix this, I either need to move running lintian
back into debuild or dpkg needs to not error when the check command
isn't present.

A related issue I see is that the semantics of debuild's lintian hook
and dpkg-bp's check hook are different, due to this.  debuild would not
try to run lintian, but would still call the lintian hook. However, the
hook argument would be false to indicate that lintian wasn't actually
going to be run.  In other words,

diff --git i/scripts/dpkg-buildpackage.pl w/scripts/dpkg-buildpackage.pl
index 9ec0d849d..a93edfa79 100755
--- i/scripts/dpkg-buildpackage.pl
+++ w/scripts/dpkg-buildpackage.pl
@@ -366,7 +366,7 @@ if (@rootcommand and not find_command($rootcommand[0])) {
 }
 
 if ($check_command and not find_command($check_command)) {
-    error(g_("check-commmand '%s' not found"), $check_command);
+    $check_command = undef;
 }
 
 if ($signcommand) {

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB