Bug#814049: /usr/bin/uscan: uscan gives invalid example in manpage for github tags

[Ximin Luo]

Ximin Luo:
> In uscan's manpage, it gives this example for github tags:
> 
>          version=4
>          opts="filenamemangle="s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%<project>-$1.tar.gz%" \
>              https://github.com/<user>/<project>/tags \
>              (?:.*?/)?v?(\d[\d.]*)\.tar\.gz debian uupdate
> 
> [..]
> 
> uscan warn: In debian/watch, potentially unsafe or malformed filenamemangle pattern:
>   '"s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%baka-mplayer-$1.tar.gz%' found. Skipping watchline
>   https://github.com/u8sand/Baka-MPlayer/tags (?:.*?/)?v?(\d[\d.]*)\.tar\.gz debian uupdate
> 1

OK, this can be fixed by changing 'filenamemangle="' to 'filenamemangle=' (remove the double-quote).

However, the error message is still pretty vague. What does "unsafe" mean? Could you at least make two different error messages for the "unsafe" vs "malformed" cases?

Also I am getting this as further output:

~~~~
uscan: Don't downloading upstream package: baka-mplayer-2.0.4.tar.gz
uscan: Start checking for common possible upstream OpenPGP signature files
uscan: End checking for common possible upstream OpenPGP signature files
uscan: Successfully downloaded package baka-mplayer-2.0.4.tar.gz
uscan warn: No upstream tarball downloaded.  No further processing with mk_origtargz ...
1
~~~~

No actual tarball is download, but it's not obvious given the final two messages state directly opposite things.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git