Bug#814447: devscripts: uscan(1) github example is rejected with "potentially unsafe or malformed filenamemangle pattern"

[James McCoy]

On Thu, Feb 11, 2016 at 11:40:09AM -0500, Daniel Kahn Gillmor wrote:
> the github example in uscan(1) appears to be rejected by uscan as
> having a "potentially unsafe or malformed filenamemangle pattern".
> 
> It's not clear to me what the problem is or how i should resolve it.
> either the documentation or the definition of safe_replace() in
> scripts/uscan.pl should be updated so that they're aligned.
> 
> Here is an example:
> 
> 0 dkg at alice:~/src/win-iconv/win-iconv$ man uscan | grep -A10 'For GitHub based'
>        For GitHub based projects, you can use the tags or releases page.  The
>        archive URL uses only the version as the filename.  You can rename the
>        downloaded upstream tarball from into the standard
>        <project>-<version>.tar.gz using filenamemangle:
> 
>          version=4
>          opts="filenamemangle="s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%<project>-$1.tar.gz%" \
                            ----^
There's an extraneous " in the example.  This was originally reported in
#814049, but that has been repurposed to fix the wording of the error.

The example itself is fixed in git, which we'll be uploading soon.

Cheers,
James