Bug#810976: [uscan] Ignores non-zero exitcode of "action"

[Osamu Aoki]

Hi,

FYI: uscan 2.15.9 is broken if used with --destdir

On Thu, Jan 14, 2016 at 01:12:31PM +0100, Ben Wiederhake wrote:
> Package: devscripts
> Version: 2.15.9
> Severity: normal
> File: /usr/bin/uscan
> 
> Dear Maintainer,
> 
> when using a watchfile with an action, the exit-code is ignored.
> This is problematic, because if the "action" is required to produce a working
> orig tarball, this silently fails.

Are you talking a script like "uupdate" as "action"?

> Here's the invocation of uscan I used:
> 
>     uscan --noconf --verbose --rename --destdir=/home/user/workspace/telegram-
> purple \
>           --check-dirname-level=0 --force-download --download-version
> "1.2.5~beta" \
>           /home/user/workspace/telegram-purple/debian
> 
> Here's the actual behavior, truncated to the relevant part:
> 
>     -- Executing user specified script
>          /bin/false --upstream-version 1.2.5~beta /home/eispin/workspace
> /telegram-purple/telegram-purple_1.2.5~beta.orig.tar.gz
>     -- Scan finished
>     user at xpected:~/workspace/telegram-purple$ echo $?
>     0
> 
> Here's what I would have liked to see:
> 
>     -- Executing user specified script
>          /bin/false --upstream-version 1.2.5~beta /home/user/workspace
> /telegram-purple/telegram-purple_1.2.5~beta.orig.tar.gz
>     -- Scan aborted: user specified script failed
>     user at xpected:~/workspace/telegram-purple$ echo $?
>     1

OK.  So pass exit status of the script ...

As I glanced for code both mk-origtargz and uupdate execution don't
use exit code.  Or many other shell command execution in this code in
general.  Something to think before coding ...
 
> (or something like it)
> 
> The BTS doesn't know anything about this, and 2.15.10 (unstable) doesn't seem
> to fix this, according to the changelog.

True.