[devscripts] 01/02: dd-list: make the file argument of the '-s' option mandatory

[James McCoy]

This is an automated email from the git hooks/post-receive script.

jamessan pushed a commit to branch master
in repository devscripts.

commit 0124a9f2debb5bbcaa5406fae800c76d2510ed62
Author: Niko Tyni <ntyni at debian.org>
Date:   Sun Jun 5 12:57:38 2016 +0300

    dd-list: make the file argument of the '-s' option mandatory
    
    As discussed in https://rt.cpan.org/Public/Bug/Display.html?id=39052
    dd-list was relying on buggy Getopt::Long behaviour to parse 'dd-list -s
    <sources>': GNU getopt compatibility would require 'dd-list -s=<sources>'
    for optional arguments.
    
    There doesn't seem to be a use case for specifying '-s' without a
    source file, so fix the problem by making it mandatory.
    
    Signed-off-by: James McCoy <jamessan at debian.org>
---
 scripts/dd-list.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/dd-list.pl b/scripts/dd-list.pl
index 71f277c..f7c4b50 100755
--- a/scripts/dd-list.pl
+++ b/scripts/dd-list.pl
@@ -100,7 +100,7 @@ GetOptions(
     "help|h" => sub { help(); exit },
     "stdin|i" => \$use_stdin,
     "dctrl|d" => \$use_dctrl,
-    "sources|s:s@" => \$source_files,
+    "sources|s=s@" => \$source_files,
     "uploaders|u!" => \$show_uploaders,
     'z|uncompress' => \$opt_uncompress,
     "print-binary|b" => \$print_binary,

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/collab-maint/devscripts.git