[devscripts] 01/01: build-rdeps: add dose-ceve support

Osamu Aoki osamu at moszumanska.debian.org
Tue Mar 8 14:44:48 UTC 2016


This is an automated email from the git hooks/post-receive script.

osamu pushed a commit to branch master
in repository devscripts.

commit 42f9462a19d92380197c529aebd3815b2e6d7939
Author: Johannes Schauer <josch at debian.org>
Date:   Sat Aug 29 08:55:49 2015 +0200

    build-rdeps: add dose-ceve support
    
    Closes: #797858
---
 debian/changelog       |   4 +
 debian/control         |   3 +-
 scripts/build-rdeps.pl | 222 ++++++++++++++++++++++++++++++++++++++++++-------
 3 files changed, 199 insertions(+), 30 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index fa3db90..d2cddce 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -30,6 +30,10 @@ devscripts (2.16.2) UNRELEASED; urgency=medium
     + Report excuses even when autoremoval info isn't reachable.  (Closes:
       #816723)
 
+  [ Johannes Schauer ]
+  * build-rdeps:
+    + Improve dependency resolver using dose3.  Closes: #797858
+
  -- Osamu Aoki <osamu at debian.org>  Sat, 13 Feb 2016 22:10:05 +0900
 
 devscripts (2.16.1) unstable; urgency=medium
diff --git a/debian/control b/debian/control
index 07aab3e..18babc7 100644
--- a/debian/control
+++ b/debian/control
@@ -79,6 +79,7 @@ Suggests: bsd-mailx | mailx,
           cvs-buildpackage,
           debbindiff,
           devscripts-el,
+          dese-extra (>= 4.0),
           gnuplot,
           gpgv | gpgv2,
           libauthen-sasl-perl,
@@ -106,7 +107,7 @@ Description: scripts to make the life of a Debian Package maintainer easier
     libauthen-sasl-perl, libnet-smtp-ssl-perl, libsoap-lite-perl, liburi-perl,
     libwww-perl, bsd-mailx | mailx]
   - build-rdeps: search for all packages that build-depend on a given package
-    [dctrl-tools]
+    [dctrl-tools, dose-extra]
   - chdist: tool to easily play with several distributions [dctrl-tools]
   - checkbashisms: check whether a /bin/sh script contains any common
     bash-specific contructs
diff --git a/scripts/build-rdeps.pl b/scripts/build-rdeps.pl
index 796bf6a..89cfc39 100755
--- a/scripts/build-rdeps.pl
+++ b/scripts/build-rdeps.pl
@@ -1,5 +1,6 @@
 #!/usr/bin/perl
 #   Copyright (C) Patrick Schoenfeld
+#                 2015 Johannes Schauer <josch at debian.org>
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -27,6 +28,18 @@ B<build-rdeps> I<package>
 
 B<build-rdeps> searches for all packages that build-depend on the specified package.
 
+The default behaviour is to just `grep` for the given dependency in the
+Build-Depends field of apt's Sources files.
+
+If the package dose-extra >= 4.0 is installed, then a more complete reverse
+build dependency computation is carried out. In particular, with that package
+installed, build-rdeps will find transitive reverse dependencies, respect
+architecture and build profile restrictions, take Provides relationships,
+Conflicts, Pre-Depends, Build-Depends-Arch and versioned dependencies into
+account and correctly resolve multiarch relationships for crossbuild reverse
+dependency resolution.  (This tends to be a slow process due to the complexity
+of the package interdependencies.)
+
 =head1 OPTIONS
 
 =over 4
@@ -59,6 +72,28 @@ Restrict the search to only the specified origin (such as "Debian").
 
 Print the value of the maintainer field for each package.
 
+=item B<--host-arch>
+
+Explicitly set the host architecture. The default is the value of
+`dpkg-architecture -qDEB_HOST_ARCH`. This option only works if dose-extra >=
+4.0 is installed.
+
+=item B<--old>
+
+Force the old simple behaviour without dose-ceve support even if dose-extra >=
+4.0 is installed.  (This tends to be faster.)
+
+Notice, that the old behaviour only finds direct dependencies, ignores virtual
+dependencies, does not find transitive dependencies and does not take version
+relationships, architecture restrictions, build profiles or multiarch
+relationships into account.
+
+=item B<--build-arch>
+
+Explicitly set the build architecture. The default is the value of
+`dpkg-architecture -qDEB_BUILD_ARCH`. This option only works if dose-extra >=
+4.0 is installed.
+
 =item B<-d>, B<--debug>
 
 Run the debug mode
@@ -99,6 +134,8 @@ my $version = '1.0';
 my $dctrl = "grep-dctrl";
 my $sources_path = "/var/lib/apt/lists/";
 my $release_pattern = '(.*_dists_(sid|unstable))_(?:In)*Release$';
+my $use_ceve = 0;
+my $ceve_compatible;
 my %seen_origins;
 my @source_files;
 my $opt_debug;
@@ -109,6 +146,9 @@ my $opt_mainonly;
 my $opt_distribution;
 my $opt_origin = 'Debian';
 my @opt_exclude_components;
+my $opt_buildarch;
+my $opt_hostarch;
+my $opt_without_ceve;
 
 if (system('command -v grep-dctrl >/dev/null 2>&1')) {
 	die "$progname: Fatal error. grep-dctrl is not available.\nPlease install the 'dctrl-tools' package.\n";
@@ -145,11 +185,32 @@ Options:
                                   (Default: Debian)
    --only-main                    Ignore contrib and non-free
    --exclude-component COMPONENT  Ignore the specified component (can be given multiple times)
+   --host-arch                    Set the host architecture (requires dose-extra >= 4.0)
+   --build-arch                   Set the build architecture (requires dose-extra >= 4.0)
+   --old                          Use the old simple reverse dependency resolution
 
 EOT
 version;
 }
 
+sub test_ceve {
+    return $ceve_compatible if defined $ceve_compatible;
+
+    # test if the debsrc input and output format is supported by the installed
+    # ceve version
+    system('dose-ceve -T debsrc debsrc:///dev/null > /dev/null 2>&1');
+    if ($? == -1) {
+	print STDERR "DEBUG: dose-ceve cannot be executed: $!\n" if ($opt_debug);
+	$ceve_compatible = 0;
+    } elsif ($? == 0) {
+	$ceve_compatible = 1;
+    } else {
+	print STDERR "DEBUG: dose-ceve is too old\n" if ($opt_debug);
+	$ceve_compatible = 0;
+    }
+    return $ceve_compatible;
+}
+
 # Sub to test if a given section shall be included in the result
 sub test_for_valid_component {
     my $filebase = shift;
@@ -168,6 +229,28 @@ sub test_for_valid_component {
 	return -1;
     }
 
+    if ($use_ceve) {
+	die "build arch undefined" if ! defined $opt_buildarch;
+	die "host arch undefined" if ! defined $opt_hostarch;
+	my $packages_path = "$sources_path/$filebase";
+	if ($filebase !~ /_source_Sources$/) {
+	    print STDERR "Warning: Ignoring sources file $filebase because of unexpected postfix\n";
+	    return -1;
+	}
+	$packages_path =~ s/_source_Sources$/_binary-${opt_buildarch}_Packages/;
+	if (! -e $packages_path) {
+	    print STDERR "Warning: Ignoring sources file $filebase because no corresponding buildarch Packages file for $opt_buildarch was found (required for ceve)\n";
+	    return -1;
+	}
+	if ($opt_buildarch ne $opt_hostarch) {
+	    $packages_path =~ s/_source_Sources$/_binary-${opt_hostarch}_Packages/;
+	    if (! -e $packages_path) {
+		print STDERR "Warning: Ignoring sources file $filebase because no corresponding buildarch Packages file for $opt_hostarch was found (required for ceve)\n";
+		return -1;
+	    }
+	}
+    }
+
     print STDERR "DEBUG: Component ($filebase) may not be excluded.\n" if ($opt_debug);
     return 0;
 }
@@ -215,46 +298,74 @@ sub addsources {
 
 sub findreversebuilddeps {
 	my ($package, $source_file) = @_;
-	my %packages;
-	my $depending_package;
 	my $count=0;
-	my $maintainer_info='';
 
-	open(PACKAGES, '-|', $dctrl, '-r', '-F', 'Build-Depends,Build-Depends-Indep', "\\(^\\|, \\)$package", '-s', 'Package,Build-Depends,Build-Depends-Indep,Maintainer', $source_file);
+	if ($use_ceve) {
+		die "build arch undefined" if ! defined $opt_buildarch;
+		die "host arch undefined" if ! defined $opt_hostarch;
 
-	while(<PACKAGES>) {
-		chomp;
-		print STDERR "$_\n" if ($opt_debug);
-		if (/Package: (.*)$/) {
-			$depending_package = $1;
-			$packages{$depending_package}->{'Build-Depends'} = 0;
+		(my $buildarch_file = $source_file) =~ s/_source_Sources$/_binary-${opt_buildarch}_Packages/;
+
+		my $ceve_cmd = "dose-ceve -T debsrc -r $package -G pkg"
+			. " --deb-native-arch=$opt_buildarch deb://$buildarch_file"
+			. " debsrc://$source_file";
+		if ($opt_buildarch ne $opt_hostarch) {
+			$ceve_cmd .= " --deb-host-arch=$opt_hostarch";
+			(my $hostarch_file = $source_file) =~ s/_source_Sources$/_binary-${opt_hostarch}_Packages/;
+			$ceve_cmd .= " deb://$hostarch_file";
 		}
-		elsif (/Maintainer: (.*)$/) {
-			if ($depending_package) {
-				$packages{$depending_package}->{'Maintainer'} = $1;
+		$ceve_cmd .= " | grep-dctrl -n -s Package '' | sort -u |";
+		print STDERR "DEBUG: executing: $ceve_cmd" if ($opt_debug);
+		open(SOURCES, $ceve_cmd);
+		while(<SOURCES>) {
+			chomp;
+			print "$_";
+			if ($opt_maintainer) {
+			    my $maintainer = `apt-cache showsrc $_ | grep-dctrl -n -s Maintainer '' | sort -u`;
+			    print " ($maintainer)";
 			}
+			print "\n";
+			$count += 1;
 		}
-		elsif (/Build-Depends: (.*)$/ or /Build-Depends-Indep: (.*)$/) {
-			if ($depending_package) {
-				print STDERR "$1\n" if ($opt_debug);
-				if ($1 =~ /^(.*\s)?\Q$package\E(?::[a-zA-Z0-9][a-zA-Z0-9-]*)?([\s,]|$)/) {
-					$packages{$depending_package}->{'Build-Depends'} = 1;
+	} else {
+		my %packages;
+		my $depending_package;
+		open(PACKAGES, '-|', $dctrl, '-r', '-F', 'Build-Depends,Build-Depends-Indep', "\\(^\\|, \\)$package", '-s', 'Package,Build-Depends,Build-Depends-Indep,Maintainer', $source_file);
+
+		while(<PACKAGES>) {
+			chomp;
+			print STDERR "$_\n" if ($opt_debug);
+			if (/Package: (.*)$/) {
+				$depending_package = $1;
+				$packages{$depending_package}->{'Build-Depends'} = 0;
+			}
+			elsif (/Maintainer: (.*)$/) {
+				if ($depending_package) {
+					$packages{$depending_package}->{'Maintainer'} = $1;
+				}
+			}
+			elsif (/Build-Depends: (.*)$/ or /Build-Depends-Indep: (.*)$/) {
+				if ($depending_package) {
+					print STDERR "$1\n" if ($opt_debug);
+					if ($1 =~ /^(.*\s)?\Q$package\E(?::[a-zA-Z0-9][a-zA-Z0-9-]*)?([\s,]|$)/) {
+						$packages{$depending_package}->{'Build-Depends'} = 1;
+					}
 				}
 			}
 		}
-	}
 
-	while($depending_package = each(%packages)) {
-		if ($packages{$depending_package}->{'Build-Depends'} != 1) {
-			print STDERR "Ignoring package $depending_package because its not really build depending on $package.\n" if ($opt_debug);
-			next;
-		}
-		print $depending_package;
-		if ($opt_maintainer) {
-			print " ($packages{$depending_package}->{'Maintainer'})";
+		while($depending_package = each(%packages)) {
+			if ($packages{$depending_package}->{'Build-Depends'} != 1) {
+				print STDERR "Ignoring package $depending_package because its not really build depending on $package.\n" if ($opt_debug);
+				next;
+			}
+			print $depending_package;
+			if ($opt_maintainer) {
+				print " ($packages{$depending_package}->{'Maintainer'})";
+			}
+			print "\n";
+			$count+=1;
 		}
-		print "\n";
-		$count+=1;
 	}
 
 	if ($count == 0) {
@@ -276,6 +387,12 @@ GetOptions(
 	"only-main" => \$opt_mainonly,
 	"exclude-component=s" => \@opt_exclude_components,
 	"origin=s" => \$opt_origin,
+	"host-arch=s" => \$opt_hostarch,
+	"build-arch=s" => \$opt_buildarch,
+#	"profiles=s" => \$opt_profiles, # FIXME: add build profile support
+#	                                         once dose-ceve has a
+#	                                         --deb-profiles option
+	"old" => \$opt_without_ceve,
 	"d|debug" => \$opt_debug,
 	"h|help" => sub { usage; },
 	"v|version" => sub { version; }
@@ -289,6 +406,53 @@ if (!$package) {
 
 print STDERR "DEBUG: Package => $package\n" if ($opt_debug);
 
+if ($opt_hostarch) {
+    if ($opt_without_ceve) {
+	die "$progname: the --host-arch option cannot be used together with --old\n";
+    }
+    if (test_ceve()) {
+	$use_ceve = 1;
+    } else {
+	die "$progname: the --host-arch option requires dose-extra >= 4.0 to be installed\n";
+    }
+}
+
+if ($opt_buildarch) {
+    if ($opt_without_ceve) {
+	die "$progname: the --build-arch option cannot be used together with --old\n";
+    }
+    if (test_ceve()) {
+	$use_ceve = 1;
+    } else {
+	die "$progname: the --build-arch option requires dose-extra >= 4.0 to be installed\n";
+    }
+}
+
+# if ceve usage has not been activated yet, check if it can be activated
+if (!$use_ceve and !$opt_without_ceve) {
+    if (test_ceve()) {
+	$use_ceve = 1;
+    } else {
+	print STDERR "WARNING: dose-extra >= 4.0 is not installed. Falling back to old unreliable behaviour.\n";
+    }
+}
+
+if ($use_ceve) {
+    # set hostarch and buildarch if they have not been set yet
+    if (!$opt_hostarch) {
+	$opt_hostarch = `dpkg-architecture --query DEB_HOST_ARCH`;
+	chomp $opt_hostarch;
+    }
+    if (!$opt_buildarch) {
+	$opt_buildarch = `dpkg-architecture --query DEB_BUILD_ARCH`;
+	chomp $opt_buildarch;
+    }
+    print STDERR "DEBUG: running with dose-ceve resolver\n" if ($opt_debug);
+    print STDERR "DEBUG: buildarch=$opt_buildarch hostarch=$opt_hostarch\n" if ($opt_debug);
+} else {
+    print STDERR "DEBUG: running with old resolver\n" if ($opt_debug);
+}
+
 if ($opt_update) {
 	print STDERR "DEBUG: Updating apt-cache before search\n" if ($opt_debug);
 	my @cmd;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/collab-maint/devscripts.git



More information about the devscripts-devel mailing list