Bug#834317: devscripts: please warn if DEBUILD_DPKG_BUILDPACKAGE_OPTS contains "-i -I" or similar

[James McCoy]

On Sun, Aug 14, 2016 at 01:43:27PM +0100, Chris Lamb wrote:
> If you take a look at:
> 
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=735377#44
> 
> Here, Holger hit a problem in the past because he had "-i -I" in the
> DEBUILD_DPKG_BUILDPACKAGE_OPTS variable instead of in (I guess)
> DEBUILD_LINTIAN_OPTS.

No, I'm pretty sure Holger meant to have them in
DEBUILD_DPKG_BUILDPACKAGE_OPTS.  From dpkg-buildpackage(1)

       -i, --diff-ignore[=regex]
       -I, --tar-ignore[=pattern]
       …
              Passed unchanged to dpkg-source. See its manual page.

It uses a pre-canned set of values to exclude common paths that
shouldn't be part of the source package.

> This was causing some files to be omitted from the binary, resulting
> in some FTBFS. For example #834315.

Although that's unfortunate, I don't see it as a reason to warn about
this as the same would happen if a user manually ran “dpkg-buildpackage
-i -I”.  I'm inclined to close this.

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB