Bug#850655: devscripts: dscverify calls gpg by absolute path

[Ian Jackson]

Package: devscripts
Version: 2.16.10
Severity: minor

dscverify does this:

    my $havegpg = first { -x $_ } qw(/usr/bin/gpg2 /usr/bin/gpg);

Please could you replace the absolute paths with a pair of calls to
File::Which ?  Something like this:

 +  use File::Which;
 ...
 +  my $havegpg = first { which $_ } qw(gpg2 gpg);

You will want to Recommend or Suggest libfile-which-perl.

I can supply a proper patch if you like.

(This is annoying me slightly because the dgit test suite has to
provide a stunt version of gpg on PATH in order to tell gpg to tell
gpg-agent to be sloppy but fast about random number generation.  When
it so happens that the agent ends up started via dscverify, I end up
with some slowness.

But anyway, policy says look on PATH and that is what programs should
do.)

Thanks,
Ian.

-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
DEBSIGN_KEYID=0x48B50D39

-- System Information:
Debian Release: stretch/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages devscripts depends on:
ii  dpkg-dev     1.18.15
ii  libc6        2.24-8
ii  perl         5.24.1~rc4-1
pn  python3:any  <none>

Versions of packages devscripts recommends:
ii  apt                         1.4~beta2
pn  at                          <none>
ii  curl                        7.51.0-1
ii  dctrl-tools                 2.24-2
ii  debian-keyring              2016.09.04
ii  dput                        0.11.0
pn  equivs                      <none>
ii  fakeroot                    1.21-2
ii  file                        1:5.29-1
ii  gnupg                       2.1.17-3+~iwj
ii  gnupg2                      2.1.16-3
pn  libdistro-info-perl         <none>
ii  libencode-locale-perl       1.05-1
ii  liblwp-protocol-https-perl  6.06-2
ii  libsoap-lite-perl           1.20-1
ii  liburi-perl                 1.71-1
ii  libwww-perl                 6.15-1
pn  licensecheck                <none>
ii  lintian                     2.5.49
ii  man-db                      2.7.5-2
ii  patch                       2.7.5-1
ii  patchutils                  0.3.4-2
ii  python3-debian              0.1.29
pn  python3-magic               <none>
ii  sensible-utils              0.0.9
ii  strace                      4.13-0.1
ii  unzip                       6.0-20
ii  wdiff                       1.2.2-1+b1
ii  wget                        1.18-4
ii  xz-utils                    5.2.2-1.2

Versions of packages devscripts suggests:
pn  adequate                     <none>
ii  autopkgtest                  4.2.2
pn  bls-standalone               <none>
ii  build-essential              12.2
pn  check-all-the-things         <none>
pn  cvs-buildpackage             <none>
ii  devscripts-el                36.3
pn  diffoscope                   <none>
pn  disorderfs                   <none>
pn  dose-extra                   <none>
pn  duck                         <none>
pn  faketime                     <none>
pn  gnuplot                      <none>
ii  gpgv                         2.1.17-3+~iwj
pn  how-can-i-help               <none>
ii  libauthen-sasl-perl          2.1600-1
ii  libfile-desktopentry-perl    0.22-1
pn  libnet-smtps-perl            <none>
pn  libterm-size-perl            <none>
ii  libtimedate-perl             2.3000-2
pn  libyaml-syck-perl            <none>
ii  mailutils [mailx]            1:2.99.99-1.1+b1
pn  mozilla-devscripts           <none>
pn  mutt                         <none>
ii  openssh-client [ssh-client]  1:7.3p1-5
pn  piuparts                     <none>
pn  ratt                         <none>
pn  reprotest                    <none>
pn  svn-buildpackage             <none>
ii  w3m                          0.5.3-33

-- no debconf information