Bug#868067: /usr/bin/uscan: hard-coded uupdate script name for different behavior

[Vincent Danjean]

Package: devscripts
Version: 2.17.8
Severity: normal
File: /usr/bin/uscan

When invoking the update script, uscan contains code that differ depending on
the script name, ie "uupdate" or something else.
  It is a problem when you want to run a script to workaround a problem in
the tarball but then run uupdate. For example, I tried:
* in debian/watch
... debian debian/uupdate
* in debian/uupdate
#!/bin/bash
...
exec uupdate "$@"

=> it fails because the "debian/uupdate" script is not invoked with the
same options that would be used with the "uupdate" script.
  In uscan, the offending lines are near the 3800 line:
            if ($cmd[0] eq "uupdate") {
                push @cmd, "-f";
...

Why this hard-coded test?

If you do not want to break backward compatibility, can you add an
uscan option (uupdate-options=true?) that the maintainer can add in
debian/watch so that the provided update script is run with the same
parameters the uupdate script would be? 
	
  Regards,
    Vincent

-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
DSCVERIFY_KEYRINGS=$HOME/.gnupg/pubring.gpg
DEBUILD_DPKG_BUILDPACKAGE_OPTS=-k0xD17897FA
DEBSIGN_KEYID=0x7EC7B751

-- System Information:
Debian Release: buster/sid
  APT prefers oldstable-updates
  APT policy: (500, 'oldstable-updates'), (500, 'unstable'), (500, 'testing'), (200, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armel, mipsel

Kernel: Linux 4.7.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages devscripts depends on:
ii  dpkg-dev              1.18.24
ii  libc6                 2.24-12
ii  libfile-homedir-perl  1.00-1
ii  perl                  5.24.1-4
ii  python3               3.5.3-3

Versions of packages devscripts recommends:
ii  apt                         1.5~beta1
ii  at                          3.1.20-3
ii  curl                        7.52.1-5
ii  dctrl-tools                 2.24-2+b1
ii  debian-keyring              2017.05.28
ii  dput                        0.12.1
ii  equivs                      2.0.10
ii  fakeroot                    1.21-3.1
ii  file                        1:5.30-1
ii  gnupg                       2.1.18-8
ii  gnupg2                      2.1.18-8
ii  libdistro-info-perl         0.15
ii  libdpkg-perl                1.18.24
ii  libencode-locale-perl       1.05-1
ii  libgit-wrapper-perl         0.047-1
ii  liblist-compare-perl        0.53-1
ii  liblwp-protocol-https-perl  6.06-2
ii  libsoap-lite-perl           1.20-1
ii  liburi-perl                 1.71-1
ii  libwww-perl                 6.15-1
ii  licensecheck                3.0.30-1
ii  lintian                     2.5.51
ii  man-db                      2.7.6.1-2
ii  patch                       2.7.5-1+b2
ii  patchutils                  0.3.4-2
ii  python3-debian              0.1.30
ii  python3-magic               1:5.30-1
ii  python3-unidiff             0.5.2-1
ii  sensible-utils              0.0.9
ii  strace                      4.15-2
ii  unzip                       6.0-21
ii  wdiff                       1.2.2-2
ii  wget                        1.19.1-4
ii  xz-utils                    5.2.2-1.2+b1

Versions of packages devscripts suggests:
pn  adequate                     <none>
ii  autopkgtest                  4.4
pn  bls-standalone               <none>
ii  bsd-mailx [mailx]            8.1.2-0.20160123cvs-4
ii  build-essential              12.3
pn  check-all-the-things         <none>
pn  cvs-buildpackage             <none>
pn  devscripts-el                <none>
pn  diffoscope                   <none>
pn  disorderfs                   <none>
pn  dose-extra                   <none>
pn  duck                         <none>
ii  faketime                     0.9.6-7+b1
ii  gnuplot                      5.0.5+dfsg1-7
ii  gpgv                         2.1.18-8
pn  how-can-i-help               <none>
ii  libauthen-sasl-perl          2.1600-1
ii  libfile-desktopentry-perl    0.22-1
pn  libnet-smtps-perl            <none>
pn  libterm-size-perl            <none>
ii  libtimedate-perl             2.3000-2
ii  libyaml-syck-perl            1.29-1+b2
pn  mozilla-devscripts           <none>
ii  mutt                         1.8.3+neomutt20170609-2
ii  openssh-client [ssh-client]  1:7.5p1-5
pn  piuparts                     <none>
ii  quilt                        0.63-8
pn  ratt                         <none>
pn  reprotest                    <none>
ii  svn-buildpackage             0.8.6
ii  w3m                          0.5.3-34

-- no debconf information