Bug#881825: devscripts: sadt: does not parse tests separated by commas

Geoffrey Thomas geofft at ldpreload.com
Wed Nov 15 15:22:48 UTC 2017


Package: devscripts
Version: 2.17.11
User: devscripts at packages.debian.org
Usertags: sadt

The autopkgtest spec says that test names can be separated by "comma 
and/or whitespace" [1]. sadt only understands tests separated by 
whitespace:

$ mkdir -p debian/tests
$ echo 'Source: foo' > debian/control
$ echo 'Tests: one, two' > debian/tests/control
$ ln -s /bin/true debian/tests/one
$ ln -s /bin/true debian/tests/two
$ sadt -v
one, ... SKIP (debian/tests/one, could not be made executable: [Errno 2] No such file or directory: 'debian/tests/one,')
two ... ok
----------------------------------------------------------------------
Ran 2 tests

OK (skipped=1)

autopkgtest itself implements this with .replace(',', ' ').split() [2], 
which seems reasonable. Also the spec isn't clear but it looks like the 
same should be done with restrictions and features.

If you would like me to commit this change to the collab-maint repo, let 
me know. I've confirmed that it does fix the problem.

[1] https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
[2] https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/lib/testdesc.py?h=4.3#n413

-- 
Geoffrey Thomas
https://ldpreload.com
geofft at ldpreload.com



More information about the devscripts-devel mailing list