[devscripts] branch master updated (96b67fa -> 8536b84)

[Osamu Aoki]

Hi,

On Sat, Sep 30, 2017 at 10:53:12AM +0200, Christoph Berg wrote:
> Re: Osamu Aoki 2017-09-30 <20170930002527.er6whbjmtqjrqecj at goofy.tc4.so-net.ne.jp>
> > No download.  Come to think of, this is expected.  You requested
> > USCAN_DOWNLOAD=no and it was honored.
> > 
> > If you add "--download" to command line, it download as my first case.
> > 
> > If I automatically enable "--download" even when "--no-download" for
> > scan only operation of --download-current-version becomes impossible.
> > So this is intentional choice.
> 
> I'd think command line options should override config file settings,
> so --download-current-version should imply --download which in turn
> overrides USCAN_DOWNLOAD=no.

I have been wondering about this.  I was trying to be on the safe side
to honor --no-download over other conflicting settings as my first move.
It's a tough call.  (My initial update code before pushing it to alioth
was without checking $download != 0.)

> I can live with the current behavior, though - "origtargz" works now,
> and plain "uscan --download" will now also download the file if the
> versions from debian/changelog is already the most recent tarball.

Changing uscan code is not difficult:

-$download=2 if $download != 0;
+$download=2;

But I don't find strong reason nor have guts to take this chance without
others encouraging me.  Let me discuss each case here with you to sort
this out.

 * --download-version set in the command line option
   --> maybe set $download=2 unconditionally
 * --download-debversion set in the command line option
   --> maybe set $download=2 unconditionally
 * --download-current-version set in the command line option
   --> maybe set $download=2 unconditionally

These are all command line with --download*.  So maybe I should hear
your feeling

 * "same" used as version after URL instead of "debian" in watch line
 * "previous" used as version after URL instead of "debian" in watch line

These are all watch line.  So I should honor $download == 0.

What do you and others think?

Osamu