Good but ... mk-origtargz Allow more files to be deleted than can fit inside argv (`getconf ARG_MAX`)

[Mattia Rizzolo]

On Tue, Jan 23, 2018 at 10:58:53PM +0900, Osamu Aoki wrote:
> This looks a reasonable patch.  But I don't know why you chose
> 16384=0x400 as the max figure.
> 
> Following your comment, I tried on my local machine
> $ getconf ARG_MAX
> 2097152
> 
> This is bigger than 16384.
> 
> If this is different on different system, why not dynamically check and
> set it with some safety margin like `getconf ARG_MAX` - 16 etc.?

Related lines from IRC:

Jan 13 21:39:31 <jamessan[m]>   infinity0: why a magic number in the mk-origtargz patch?
Jan 13 21:43:10 <mapreri>       (instead of running a getconf and getting the value and use it, I suppose)
Jan 13 21:45:38 <mapreri>       (and then doing some computation to turn number in something usable)
Jan 13 21:50:07 <infinity0>     jamessan[m]: it's `getconf ARG_MAX` / 128 which i felt was a reasonable path length for source filenames
Jan 13 21:50:33 <infinity0>     and worked in practise for me (larger values like 30000 broke)
Jan 13 21:56:52 <mapreri>       infinity0: yes, but why not detecting it at runtime (and a comment explaining why 128 is better than NAME_MAX=255)
Jan 13 21:57:09 <infinity0>     because it would involve more perl code


So I agree.  Please don't merge that as it is until somebody does what's
written here ↑.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20180123/803c38de/attachment.sig>