[Dh-make-php-devel] Re: [Dh-make-php-commits] r178 - trunk

[Charles Fry]

> Author: steinm
> Date: 2006-05-30 08:39:02 +0000 (Tue, 30 May 2006)
> New Revision: 178
> 
> Modified:
>    trunk/pear.mk
> Log:
> - check for xsltproc when cheching for pear and xml

This check is not necessary. dh-make-php depends on php-pear, xsltproc,
and xmlstarlet so none of them need be explicitely checked for.

> - xmlstarlet is actually called xml

See bug #312932. The binary name is incorrectly different on different
architectures. This is a serious issue that needs to be addressed before
we upload the new dh-make-php.

> - check for directory tests before moving it.

I don't fully understand the logic of the change you made, but shouldn't
the mkdir be inside of the if that you added?

Charles

-- 
This cream
Makes the
Gardener's daughter
Plant her tu-lips
Where she oughter
Burma-Shave
http://burma-shave.org/jingles/1953/this_cream
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/dh-make-php-devel/attachments/20060530/092dc153/attachment.pgp