[Docker-maint] Bug#837486: golang: FTBFS with bindnow and PIE enabled

[Balint Reczey]

Source: golang
Version: 1.6.1-2
Severity: important
User: balint at balintreczey.hu
Usertags: pie-bindnow-20160906
Justification: FTBFS on amd64 with extra hardening
Tags: patch

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64 with patched GCC and dpkg.

The rebuild tested if packages are ready for a transition
enabling PIE and bindnow for amd64.

For more information about the changes to sid's dpkg and GCC please
visit:
 https://wiki.debian.org/Hardening/PIEByDefaultTransition

Relevant part (hopefully):
...
##### Testing race detector
ok      runtime/race    2.396s
ok      flag    1.005s
ok      os/exec 2.014s
==3637==ERROR: ThreadSanitizer failed to allocate 0x2710000 (40960000)
bytes at address 175c5ff8b0b00
(errno: 12)
unexpected fault address 0x0
fatal error: fault
[signal 0x7 code=0x80 addr=0x0 pc=0x55717f9dd245]

goroutine 1 [running, locked to thread]:
runtime.throw(0x0, 0x55717f808e88)
        /<<PKGBUILDDIR>>/src/runtime/panic.go:547 +0x90
fp=0x7fff183185a0 sp=0x7fff18318588

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
        /<<PKGBUILDDIR>>/src/runtime/asm_amd64.s:1998 +0x1
fp=0xc820038fb8 sp=0xc820038fb0
exit status 2
FAIL    _/<<PKGBUILDDIR>>/misc/cgo/test 0.005s
2016/09/05 20:38:54 Failed: exit status 1
==2753==ERROR: ThreadSanitizer failed to allocate 0x26e8000 (40796160)
bytes at address 17818149c4680
(errno: 12)
unexpected fault address 0x0
fatal error: fault
[signal 0x7 code=0x80 addr=0x0 pc=0x560604f0c0e5]

goroutine 1 [running, locked to thread]:
runtime.throw(0x0, 0x560604de0378)
        /<<PKGBUILDDIR>>/src/runtime/panic.go:547 +0x90
fp=0x7ffe958b44c0 sp=0x7ffe958b44a8

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
        /<<PKGBUILDDIR>>/src/runtime/asm_amd64.s:1998 +0x1
FAIL    flag    0.005s
==3009==ERROR: ThreadSanitizer failed to allocate 0x2720000 (41025536)
bytes at address 175e931970700
(errno: 12)
unexpected fault address 0x0
fatal error: fault
[signal 0x7 code=0x80 addr=0x0 pc=0x557a4c0f6405]

goroutine 1 [running, locked to thread]:
runtime.throw(0x0, 0x557a4bd46fa8)
        /<<PKGBUILDDIR>>/src/runtime/panic.go:547 +0x90
fp=0x7ffdd2b7e910 sp=0x7ffdd2b7e8f8

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
        /<<PKGBUILDDIR>>/src/runtime/asm_amd64.s:1998 +0x1
FAIL    os/exec 0.006s
2016/09/05 20:38:54 Failed: exit status 1
...

The full build log is available from:
 https://people.debian.org/~rbalint/build-logs/pie-bindnow-20160906/golang_1.6.1-2_amd64.build.gz

Thanks,
Ubuntu fixed the issue by disabling PIE for that test-case:
https://patches.ubuntu.com/g/golang-1.6/golang-1.6_1.6.3-1ubuntu1.patch

Thanks,
Balint