[dput-ng-maint] Bug#736555: Specifying (or not specifying) a host gives python errors

[Wookey]

Package: dput-ng
Version: 1.7
Severity: important

I needed to set the permsission for a Debian Maintainer and found a
doc that said dput-ng had a 'dcut dm' option to do this.

That meant upgrading to testing as dcut-ng in not installable on
stable (due to python:any dep). A backport would be good there.

However I can't get it to do anything useful

$ dcut dm --uid 3FD37230 --allow libpaper paper psutils plptools
Traceback (most recent call last):
  File "/usr/bin/dcut", line 82, in <module>
    profile = dput.profile.load_profile(None)
  File "/usr/lib/python2.7/dist-packages/dput/profile.py", line 205, in load_profile
    obj = config.get_config(block)
  File "/usr/lib/python2.7/dist-packages/dput/profile.py", line 137, in get_config
    obj = config.get_config(name)
  File "/usr/lib/python2.7/dist-packages/dput/configs/dputcf.py", line 137, in get_config
    items = self.parser.items(name)
  File "/usr/lib/python2.7/ConfigParser.py", line 655, in items
    for option in options]
  File "/usr/lib/python2.7/ConfigParser.py", line 669, in _interpolate
    option, section, rawval, e.args[0])
ConfigParser.InterpolationMissingOptionError: Bad value substitution:
	section: [wookstuff]
	option : incoming
	key    : ppa
	rawval : ~%(ppa)s/ubuntu

Which isn't very helpful but it looks like it might be trying the
wrong upload host.

So man dput tells me I can specify one so I try some more things:

$ dcut ftpmaster dm --uid 3FD37230 --allow psutils paper libpaper
plptoolsTraceback (most recent call last):
  File "/usr/bin/dcut", line 80, in <module>
    profile = dput.profile.load_profile(known.host)
  File "/usr/lib/python2.7/dist-packages/dput/profile.py", line 200, in load_profile
    raise DputConfigurationError("Error, was given host, "
    dput.exceptions.DputConfigurationError: Error, was given host, but
we don't know about it.

Looks like the host name is blank?

I seem to get the same error whatever I put in as the second parameter

I probably just need to do some config, but the error handling here
needs to be improved. note that I am a dupload user by default so may
not have dput config correctly set up. (I did try using dput once but
it had a major shortcoming: trying to change mode on ssh uploads
_after uploading the changes file, which is incomptiable with
inotify-based things that monitor incoming (you get a race) so I went
back to dupload).

Aha 'ftp-master' works (helpful manpage example - thank-you).
So now I get a sensible error message about UIDs and keyrings, which
is fair enough.

So my bug is 'give useful error messages from unknown or
incorrectly-defaulted hosts', not a nasty python slurge.

That message could say something like 'See the 'HOST' section in the
dput manpage for details of valid names'

cheers

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dput-ng depends on:
ii  python-dput  1.7
pn  python:any   <none>

Versions of packages dput-ng recommends:
ii  bash-completion  1:2.1-2

dput-ng suggests no packages.

-- no debconf information