[Fai-commit] r3735 - trunk/lib
Henning Glawe
glaweh at debian.org
Wed Aug 2 14:22:54 UTC 2006
On Wed, Aug 02, 2006 at 01:19:21PM +0000, fai-commit at lists.alioth.debian.org wrote:
> # matched string: "cvs[+ssh]://user at host/path/to/cvsroot module[=tag]"
> -CVS_PATH=$(expr match "$FAI_CONFIG_SRC" '.*://\(\S\+\)\s\+.*')
> +dir=$(expr match "$FAI_CONFIG_SRC" '.*://\(\S\+\)\s\+.*')
as CVS_PATH also contains user and host, renaming it to 'dir' is
misleading; maybe call it user_host_dir?
Though it's longer and therefore harder to type, this would make the code a
lot clearer, especially because many people will have problems to understand
the regular expressions...
--
c u
henning
More information about the Fai-commit
mailing list