[Fai-commit] r5284 - branches/lenny/debian branches/lenny/lib/setup-storage tags/3.2.17/debian tags/3.2.17/lib/setup-storage tags/3.2.17~lenny1/debian tags/3.2.17~lenny1/lib/setup-storage trunk/debian trunk/lib/setup-storage

[Michael Tautschnig]

> Author: holger
> Date: 2009-02-25 12:31:00 +0000 (Wed, 25 Feb 2009)
> New Revision: 5284
> 
> Modified:
>    branches/lenny/debian/changelog
>    branches/lenny/lib/setup-storage/Parser.pm
>    tags/3.2.17/debian/changelog
>    tags/3.2.17/lib/setup-storage/Parser.pm
>    tags/3.2.17~lenny1/debian/changelog
>    tags/3.2.17~lenny1/lib/setup-storage/Parser.pm
>    trunk/debian/changelog
>    trunk/lib/setup-storage/Parser.pm
> Log:
> changelog entry:
> 
> +  * Fix regex in setup-storage/Parser.pm to not force a space onto VG / LV 
> +    names, which is illegal for such ids, thanks Frederic Blanc for the patch.
> +    (Closes: #516849)
> 
> Michael (T.), do you agree with this wording? (And please re-check the actual diff I commited :) It seems fine to me. :)
> 

[...]

Hmm, I'd prefer to have it reworded:

  * setup-storage/Parser.pm: Do not enforce a space after VG/LV names in
    resize/preserve options. Thanks Frederic Blanc for the patch.
    (closes: #516849)

That puts the (abbreviated) filename first (which should be consistent with
other changelog entries) and the text should be more accurate.

Thanks, Holger, for doing all the work!!

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/fai-commit/attachments/20090225/0a852bda/attachment.pgp