[Foo2zjs-maintainer] Bug#521992: Bug#521992: foo2zjs: missing icon in .desktop file

[Luca Capello]

tags 521992 + pending
thanks

Hi Gonzalo!

On Tue, 31 Mar 2009 03:58:53 +0200, Gonzalo "Bermúdez\" wrote:
> The .desktop file for "HPLJ 10xx Replaced Paper" is looking for its
> icon at /usr/share/pixmaps/hplj1020_icon.png
> This package installs a .gif file with the same name, under
> /usr/share/foo2zjs/. It is the closest I found to an icon.

The problem was simple: while building the Debian package,
/usr/share/pixmaps/ was not taken into consideration, fixed:

  http://svn.debian.org/wsvn/foo2zjs/trunk/foo2zjs_20090301dfsg/?rev=183&sc=1

Indeed, upstream sources contains both GIF and PNG files: while the
latter is for the .desktop file, the former is used in the Tcl program,
i.e. /usr/share/foo2zjs/hplj10xx_gui.tcl:

--8<---------------cut here---------------start------------->8---
proc main {w} {
    global share

    image create photo icon -file [file join $share hplj1020_icon.gif]

    frame $w.frame
    tixBalloon $w.frame.balloon
--8<---------------cut here---------------end--------------->8---

The best solution would be to use only one icon format in both the
.desktop file and the Tcl program.

IMHO the PNG format is the best choice, becasue while I could not find
any strict requirement WRT the freedesktop.org specifications, IIRC
Debian mandates menu icons to be XPM or PNG, because some WMs do not
understand anything other.

However, tk8.4 needs an external package (libtk-img) to deal with PNG
images, together with the following patch:

--8<---------------cut here---------------start------------->8---
--- hplj10xx_gui.tcl.ORG	2009-04-01 13:25:43.000000000 +0200
+++ hplj10xx_gui.tcl	2009-04-02 14:51:42.000000000 +0200
@@ -1,7 +1,8 @@
 #!/usr/bin/wish
 
 global	share
-set	share "/usr/share/foo2zjs"
+set	share "/usr/share/pixmaps"
+package require Img
 
 proc replaced {name} {
 	exec usb_printerid $name
--8<---------------cut here---------------end--------------->8---

For this latter reason I preferred to simply include two copies of the
same icon than adding yet another Debian-specific patch.

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 314 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/foo2zjs-maintainer/attachments/20090402/a3673804/attachment.pgp