[Foo2zjs-maintainer] Bug#594322: Bug#594322: foo2zjs: Please upgrade to more recent version for Squeeze.

[Till Kamppeter]

On 09/27/2010 06:53 PM, Luca Capello wrote:
>
> I have some concerns about the Ubuntu package, here the first of them, I
> will continue on another email as far as the integration progresses.
>
>
> 1) I do not understand why from version 20100210-0ubuntu1 the
>     debian/changelog contains the following:
>
>       * README.Debian: Updated completely outdated content. We are using
>         the complete original source code again for longer time as there
>         are no binary-only executables and no *.icm files any more in the
>         source tarball.
>
>     I am sorry but I do not understand why the complete original source
>     code is now DFSG, while nothing changed WRT the files we previously
>     deleted, which from the debian/changelog are:
>

Sorry, the README.Debian did not tell which files exactly were removed 
and I did not search through the debian/changelog. So I assumed that 
only these *.icm were offending.

>     - remove binary file c5200mono.prn
[...]
>     - remove crd/qpdl/CLP*, because copyright is unclear
[...]
So let us use a common source tarball again, with the files mentioned by 
you here removed. Please prepare the package, I will merge that into 
Ubuntu after the Maverick release.

>
> 2) I do not understand why some patches have been merged, like
>
>     * debian/patches/60-getweb.in.dpatch, debian/patches/80-getweb.in.dpatch:
>       merged 80-getweb.in.dpatch into 60-getweb.in.dpatch.
>
>     They fixes two different things, and they must be separated.
>

I thought to better have all for getweb in one patch. Feel free to 
separate out again this one bashism fix. I will overtake your change 
then when I make my first foo2zjs package after the Maverick release.

>
> 3) directory should be created through debian/$PKG.dirs and not by hand
>     in debian/rules (see /usr/lib/cups/filter/).
>
>     Always about the same issue, the link created by upstream's Makefile
>     is wrong, given it is not a relative one.  The correct fix would be
>     to patch upstream's Makefile, but this can be quite tedious
>     especially if upstream changes something.
>
>     While the best option seems thus to fix it in debian/rules, we should
>     use dh_link and not ln.
>

Please change this appropriately.

>
> 4) I am not sure debian/local/ is the right place for non-upstream
>     files, but I should admit that this is the first time I heard about
>     it and I can not find any documentation about that.  Nevermind, I
>     have added the two non-upstream PPDs.
>
>     BTW, conceptually speaking, Ubuntu debian/rules misses the command to
>     compress these two files, given that this action is hidden in the
>     'Add "*cupsFilter" line to accept PDF input data to the PPDs' block.
>

Please go ahead and correct also this.
I will overtake the version with your corrections to Ubuntu.

    Till