[Forensics-changes] [yara] 156/407: Fix bug in overloaded functions

[Hilko Bengen]

This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to annotated tag v3.3.0
in repository yara.

commit 0d4d71961147ce2e1ff453534a54f50e3dfc49c5
Author: Victor M. Alvarez <plusvic at gmail.com>
Date:   Wed Oct 29 14:15:57 2014 +0100

    Fix bug in overloaded functions
---
 libyara/object.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/libyara/object.c b/libyara/object.c
index 94e94e7..f1ab05e 100644
--- a/libyara/object.c
+++ b/libyara/object.c
@@ -202,15 +202,20 @@ int yr_object_function_create(
     FAIL_ON_ERROR_WITH_CLEANUP(
         yr_object_create(return_type, "result", f, &return_obj),
         yr_object_destroy(f));
+
+	((YR_OBJECT_FUNCTION*) f)->return_obj = return_obj;
   }
 
   for (i = 0; i < MAX_OVERLOADED_FUNCTIONS; i++)
+  {
     if (((YR_OBJECT_FUNCTION*) f)->prototypes[i].arguments_fmt == NULL)
-      break;
+	{
+      ((YR_OBJECT_FUNCTION*) f)->prototypes[i].arguments_fmt = arguments_fmt;
+      ((YR_OBJECT_FUNCTION*) f)->prototypes[i].code = code;
 
-  ((YR_OBJECT_FUNCTION*) f)->prototypes[i].arguments_fmt = arguments_fmt;
-  ((YR_OBJECT_FUNCTION*) f)->prototypes[i].code = code;
-  ((YR_OBJECT_FUNCTION*) f)->return_obj = return_obj;
+	  break;
+	}
+  }
 
   if (function != NULL)
     *function = f;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/forensics/yara.git