[Forensics-changes] [yara] 179/407: Remove unnecessary counter decrement

Hilko Bengen bengen at moszumanska.debian.org
Sat Jul 1 10:28:23 UTC 2017


This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to annotated tag v3.3.0
in repository yara.

commit 0e67efec6f5353fedd648385fb8fd92d8efe0a98
Author: Victor M. Alvarez <plusvic at gmail.com>
Date:   Fri Oct 31 11:45:12 2014 +0100

    Remove unnecessary counter decrement
    
    number_of_signatures shouldn't be the index for the last signature, but the actual number of signatures.
---
 libyara/modules/pe.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libyara/modules/pe.c b/libyara/modules/pe.c
index 025c6c8..7e2d851 100644
--- a/libyara/modules/pe.c
+++ b/libyara/modules/pe.c
@@ -910,10 +910,6 @@ void pe_parse_certificates(
     sk_X509_free(certs);
   }
 
-  // Decrement counter as it gets incremented one extra time erroneously.
-  if (counter > 0)
-    counter--;
-
   set_integer(counter, pe->object, "number_of_signatures");
 }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/forensics/yara.git



More information about the forensics-changes mailing list