[Forensics-changes] [guymager] 02/09: No longer Recommend gksu, switch to policykit instead

[Michael Prokop]

This is an automated email from the git hooks/post-receive script.

mika pushed a commit to branch master
in repository guymager.

commit 966f4ca6440d2a7d93a8aba12bc95791eb6f8701
Author: Michael Prokop <mika at debian.org>
Date:   Fri Jan 5 10:42:53 2018 +0100

    No longer Recommend gksu, switch to policykit instead
    
    Quoting from the bug report:
    
    | gksu has been deprecated for years. The intent of gksu is to allow
    | running apps with elevated privileges but the way to do that is for
    | the app developer to use PolicyKit to request elevated privileges for
    | the specific actions that need done instead of for the whole app to
    | run as root.
    |
    | For the next major stable release of Debian (codenamed Buster), the
    | Debian GNOME team plans to default to GNOME on Wayland where gksu does
    | not even work.
    |
    | Therefore, the Debian GNOME team intends to either remove gksu or
    | replace it with a non-functional warning message. gksu is unmaintained
    | (last upload 2014) and is a security vulnerability.
    
    Closes: #885551
    Thanks: Jeremy Bicha <jbicha at debian.org> for the bug report, thanks to Guy for feedback on pkexec
---
 debian/control                     |  2 +-
 debian/guymager.policy             | 17 +++++++++++++++++
 debian/patches/desktop_integration | 17 +++++++++++++++++
 debian/patches/series              |  1 +
 debian/rules                       |  5 +++++
 5 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index dd2ea03..8a519f6 100644
--- a/debian/control
+++ b/debian/control
@@ -29,7 +29,7 @@ Depends:
  ${misc:Depends},
  ${shlibs:Depends},
 Recommends:
- gksu,
+ policykit-1,
 Description: Forensic imaging tool based on Qt
  The forensic imager contained in this package, guymager, was designed to
  support different image file formats, to be most user-friendly and to run
diff --git a/debian/guymager.policy b/debian/guymager.policy
new file mode 100644
index 0000000..c45c554
--- /dev/null
+++ b/debian/guymager.policy
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE policyconfig PUBLIC
+ "-//freedesktop//DTD PolicyKit Policy Configuration 1.0//EN"
+ "http://www.freedesktop.org/standards/PolicyKit/1/policyconfig.dtd">
+<policyconfig>
+  <action id="guymager">
+    <message>Authentication is required to run the guymager tool</message>
+    <icon_name>guymager</icon_name>
+    <defaults>
+      <allow_any>auth_admin</allow_any>
+      <allow_inactive>auth_admin</allow_inactive>
+      <allow_active>auth_admin</allow_active>
+    </defaults>
+    <annotate key="org.freedesktop.policykit.exec.path">/usr/bin/guymager</annotate>
+    <annotate key="org.freedesktop.policykit.exec.allow_gui">true</annotate>
+  </action>
+</policyconfig>
diff --git a/debian/patches/desktop_integration b/debian/patches/desktop_integration
new file mode 100644
index 0000000..135489c
--- /dev/null
+++ b/debian/patches/desktop_integration
@@ -0,0 +1,17 @@
+From: Michael Prokop <mika at debian.org>
+Subject: Don't depend on unmaintained gksudo
+
+Bug-Debian: http://bugs.debian.org/885551
+diff --git a/guymager.desktop b/guymager.desktop
+index 1520743..825b306 100644
+--- a/guymager.desktop
++++ b/guymager.desktop
+@@ -11,7 +11,7 @@ Comment=Fast forensic imager
+ Icon=guymager_128.png
+ TryExec=guymager
+ #Exec=su-to-root -X -c guymager
+-Exec=gksudo guymager
++Exec=pkexec guymager
+ Terminal=false
+ # Categorie entry according to version 1.0 of
+ # http://www.freedesktop.org/wiki/Specifications/menu-spec
diff --git a/debian/patches/series b/debian/patches/series
index 3823ed6..ebd2426 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 adjust_compileinfo
+desktop_integration
diff --git a/debian/rules b/debian/rules
index 2d6fb4d..732ade3 100755
--- a/debian/rules
+++ b/debian/rules
@@ -34,3 +34,8 @@ override_dh_auto_clean:
 	rm -f guymager_de.qm guymager_en.qm guymager_fr.qm guymager_it.qm guymager_nl.qm
 	rm -f Makefile
 	dh_clean
+
+override_dh_auto_install:
+	dh_auto_install
+	dh_installdirs /usr/share/polkit-1/actions
+	install -m 644 debian/guymager.policy debian/guymager/usr/share/polkit-1/actions/guymager.policy

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/forensics/guymager.git