Bug#637818: aimage: FTBFS with wrong check for libssl

[Steve Langasek]

Package: aimage
Version: 3.2.4-1
Severity: serious
Tags: patch
Justification: FTBFS
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu oneiric ubuntu-patch

In addition to bug #618087, which is still present, aimage now also fails to
build because of a wrong autoconf check for libssl: the autoconf check
examines libssl for an 'ssl3_new' symbol, despite the fact that it never
*uses* this symbol at runtime.  

The attached patch corrects the autoconf check to only look for symbols that
are actually needed, and removes a wrong reference to a non-existent 'm4'
directory, allowing autoreconf to run successfully.

Since bug #618087 is still outstanding, I intend to remove the broken/FTBFS
aimage binary from the upcoming Ubuntu release.  It can be re-included if a
fixed package is made available in Debian in time.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
only in patch2:
unchanged:
--- aimage-3.2.4.orig/configure.ac
+++ aimage-3.2.4/configure.ac
@@ -13,8 +13,6 @@
 AC_PROG_CC
 AC_PROG_INSTALL
 
-AC_CONFIG_MACRO_DIR([m4])
-
 AC_CONFIG_FILES([Makefile src/Makefile])
 AC_CONFIG_FILES([aimage.spec])
 AM_CONFIG_HEADER([config.h])
@@ -56,7 +54,7 @@
 AC_CHECK_HEADERS([openssl/md5.h openssl/sha.h openssl/aes.h openssl/rsa.h openssl/rand.h]) 
 AC_CHECK_LIB([crypto],[MD5_Update],,AC_MSG_ERROR([OpenSSL required for AFFLIB]))
 # Optional libraries
-AC_CHECK_LIB([ssl],[ssl3_new],,AC_MSG_ERROR([OpenSSL library 'libssl-dev' not installed; cannot continue.]))
+AC_CHECK_LIB([ssl],[OpenSSL_add_all_digests],,AC_MSG_ERROR([OpenSSL library 'libssl-dev' not installed; cannot continue.]))
 AC_CHECK_LIB([readline],[readline],, AC_MSG_RESULT([readline not installed]))
 AC_CHECK_LIB([ncurses],[initscr],, AC_MSG_RESULT([ncurses not installed]))
 AC_CHECK_FUNCS([MD5])
only in patch2:
unchanged:
--- aimage-3.2.4.orig/Makefile.am
+++ aimage-3.2.4/Makefile.am
@@ -1,7 +1,5 @@
 SUBDIRS = src
 
-ACLOCAL_AMFLAGS = -I m4
-
 RELEASE_USER = simsong@
 RELEASE_HOST = www.afflib.org
 RELEASE_DIR  = afflib.org/