Bug#634401: extundelete: FTBFS: extundelete.cc:963:47: error: invalid use of incomplete type 'struct opaque_ext2_group_desc'

Michael Prokop mika at debian.org
Wed Jan 11 16:12:25 UTC 2012

* Eric Sandeen [Tue Jan 03, 2012 at 11:54:46AM -0600]:
> On 12/31/11 6:23 AM, Michael Prokop wrote:

> > The responsible change in e2fslibs-dev is this one ("libext2fs: make
> > fs->group_desc opaque"):

> >   http://git.kernel.org/?p=fs/ext2/e2fsprogs.git;a=commit;h=efe0b401465a3ee836180614b5b435acbb84fc27
> > The code of extundelete that's failing to compile is:

> >   http://anonscm.debian.org/gitweb/?p=forensics/extundelete.git;a=blob;f=src/extundelete.cc;h=d51d45e15081b01e32e781334ba6d431e7adf88f;hb=HEAD#l944

>         //FIXME: may need to change to be compatible with newer file systems

> :)

Yeah :)

> The point of the change was to prevent this kind of use of ->group_desc:

> group_descriptor_table[n] = fs->group_desc[n];

> because the size of group_desc may change.  Instead, we need something like:

> group_descriptor_table[n] = *ext2fs_group_desc(fs, fs->group_desc, n);

> I think my pointer-fu is ok ;)  Maybe a memcpy would be clearer.

Seems to work - thanks a lot for your help, Eric!

> There are other problems though, I think, in parse_inode_block() for example,
> things in there have changed as well... this tool seems to be getting a little
> to grubby in the ext internals.  I think maybe it should be making
> use of ext2fs_swap_inode() instead.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/forensics-devel/attachments/20120111/fe6b3997/attachment-0001.pgp>

More information about the forensics-devel mailing list