Bug#644019: reglookup: Please package latest upstream (1.0.1)

[Raphael Hertzog]

Control: tag -1 + patch

Hi,

On Fri, 05 Jun 2015, Eriberto Mota wrote:
> I can update reglookup. However, I need 10 days, because I am
> traveling now and I can't use my GPG key.

You can now base your work on this updated package:
http://http.kali.org/pool/main/r/reglookup/reglookup_1.0.1+svn282-0kali2.dsc

On Mon, 08 Jun 2015, Raphael Hertzog wrote:
> we just tried the trunk. It's better but there are still multiple
> problems:
> - LDFLAGS is not used when you link the executables (it's only used when
>   you link libregfi)
> - the default value for LDFLAGS is wrong, "-z relro" is an option for "ld" but
>   when you pass it through gcc you need "-Wl,-z,relro" 
> - I saw you tried to hack up some code to setup the SONAME... it does set
>   the SONAME on the library but the library is still installed under the
>   wrong name (libregfi.so instead of the name set in the SONAME)
> - the SONAME must not encode the full version... it's only a simple
>   counter of API/ABI compatibility. Please use "libregfi.so.0" as
>   the first SONAME (and then bump to libregfi.so.1 when you break
>   the ABI/API, etc.) (and 99.99.99.X looks really wrong as a version number :))

Tim, I hope you can fix those issues quickly now that we have identified
how to properly handle versioned libraries and that you can make a new
release.

For reference, we only have the attached two patches in use in Kali.
One to disable the build of the python module (we do it ourselves
in debian/rules) and one to use a proper versioned library.

> While lookinto in Scons support for versioned shared library I found this:
> http://stackoverflow.com/questions/2997001/how-to-get-shared-library-names-like-libhello-so-0-0-1-with-scons
> 
> http://www.scons.org/doc/production/HTML/scons-user/apb.html#b-SharedLibrary

The attached patches make use of that.

> but does not seem
> to make any difference between the version used in the filename (ideally
> libfoo.so.X.Y.Z) and the SONAME which is usually simpler (libfoo.so.X and
> which is the reason why the symlinks libfoo.so.X are needed when you
> install the library as libfoo.so.X.Y.Z). I would thus suggest to pass a
> single integer to SHLIBVERSION and not care about having a filename
> encoding the full version.
> 
> full version filename and the SONAME

That part of my last message was not supposed to be there. It's some
random text left from an initial draft that assumed that upstream support
was not working like I expected it.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-version-to-shared-library.patch
Type: text/x-diff
Size: 1686 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/forensics-devel/attachments/20150615/dd9983c4/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: drop-python-install-by-scons.patch
Type: text/x-diff
Size: 2187 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/forensics-devel/attachments/20150615/dd9983c4/attachment-0003.patch>