[Freewx-maint] Bug#721184: Problem with compiling defs.h with GCC 4.8

[Olly Betts]

Please keep the BTS in Cc.

On Thu, Aug 29, 2013 at 07:05:59PM +0200, tonda.misek at post.cz wrote:
> Hmm, I see also the _MSC_FULL_VER,..
> 
> Minimal sample producing the error is file (I used name test.cpp) with only 
> one line:
> #include <wx/string.h>
> 
> Then use:
> g++-4.8 -c `wx-config --cxxflags` -std=c++0x test.cpp

OK, the important part which meant I wasn't able to reproduce this was
-std=c++0x.  Seems GCC shouldn't really care about that here, but it
clearly does.

Looks like upstream have fixed this on trunk in the way you suggest:

https://github.com/wxWidgets/wxWidgets/commit/ef5fe20c795be38940d3f8ba4424cf26234e6d6f#include/wx/defs.h

I'll apply that patch in the next upload, but this seems relatively
minor so I'd prefer to let the last upload migrate to testing (or hit
a problem that requires another upload) before making another upload.

Cheers,
    Olly