[Freewx-maint] Bug#738849: Acknowledgement (Please enable webview support for wx3.0)

Olly Betts olly at survex.com
Thu Feb 13 19:47:55 UTC 2014


On Thu, Feb 13, 2014 at 02:08:19PM +0000, Gianfranco Costamagna wrote:
> Attaching the debdiff (I didn't bump the std-version)

Does enabling webkit support mean that the webkit runtime will become a
runtime dependency of libwxgtk3.0-0 (or is there a dynamic loading
attempt at runtime with fallback if webkit isn't installed)?

Adding an unconditional dependency on webkit means it will get dragged
in by all users of wxwidgets, when few actually need it, which isn't
going to be popular, so if it would be a hard dependency, we're going to
want to split that out into a separate package (like libwxgtk-media3.0-0
and for similar reasons).  Or implement the dynamic loading and push
that upstream.

> After further looking at the configure log I found some problems:
> - you use the embedded libnotify because you don't add the debian one

It's not an embedded copy of libnotify, but rather some generic fallback
code.  But src/generic/notifmsgg.cpp says:

// even if the platform has the native implementation, we still normally want
// to use the generic one (unless it's totally unsuitable for the target UI as
// is the case of Hildon) because it may provide more features, so include
// wx/generic/notifmsg.h to get wxGenericNotificationMessage declaration even
// if wx/notifmsg.h only declares wxNotificationMessage itself (if it already
// uses the generic version, the second inclusion will do no harm)

If the generic version is normally used anyway, building with libnotify
seems rather pointless, but I will look into this in more detail.
Thanks for pointing this out.

> - you don't enable sdl support
> - you don't enable libmspack support

Are there packages which actually need these enabling?  Just because
upstream have support for X doesn't mean we need to enable it in the
debian package.  Dragging in more dependencies is unhelpful, especially
if nobody is using them.

Cheers,
    Olly



More information about the Freewx-maint mailing list