[Freewx-maint] Bug#737050: patch for build with wx3.0-doc package

[SUGIMOTO Norimitsu]

Dear Olly.
(CC: wxWidgets Maintainers Team)

I wrote a patch create wx3.0-doc package build with
wxwidgets3.0 source package.

Please see attached file(debdiff) and merge this patch.
This patch file add call doxygen when build package.

I uploaded build log merged this patch below. 

  http://mentors.debian.net/debian/pool/main/w/wxwidgets3.0/wxwidgets3.0_3.0.2-2.dsc

regards.


On Tue, 23 Sep 2014 13:09:45 +0900
SUGIMOTO Norimitsu <dictoss at live.jp> wrote:

> Hi.
> 
> I'm sorry I slow from your response.
> 
> Your debdiff is useful, I will upload package
> on menters applied your patch.
> 
> Your proposal that replace jQuery, however it isn't replace
> jQuery file from Olly's advice. 
> https://bugs.debian.org/736360
> 
> I agree Olly's advice, because this package maintenance
> become difficult If this package depend on libjs-jquery.
> (ex. update libjs-jquery)
> 
> > For the maintainer I think freewx-maint is the best choice... But I don't have a strong opinion and I have no upload possibilities 
> 
> I have no upload authority too, then I will request to 
> DD or freewx-maint member sponsor upload.
> 
> regards.
> 
> On Tue, 2 Sep 2014 11:32:39 +0100
> Gianfranco Costamagna <costamagnagianfranco at yahoo.it> wrote:
> 
> > Hi olly,
> > 
> > 
> > 
> > 
> > > Il Lunedì 1 Settembre 2014 18:36, Olly Betts <olly at survex.com> ha scritto:
> > > > On Mon, Sep 01, 2014 at 02:52:43PM +0100, Gianfranco Costamagna wrote:
> > >>  Hi, I packaged wx3.0 doc, and after that I discovered this ITP and the
> > >>  package on mentors...
> > > 
> > > I'm happy someone's packaging it, but slightly surprised that nobody
> > > thought to mention it to the wx maintainers.
> > > 
> > >>  For the maintainer I think freewx-maint is the best choice... But I
> > >>  don't have a strong opinion and I have no upload possibilities 
> > > 
> > > It seems sensible to me for it to be under the team umbrella, since
> > > we maintain the package it is the documentation for, and coordinating
> > > uploads of new versions would be helpful to users.  I'm certainly happy
> > > for more people to join the team.
> > > 
> > >>  diff -Nru wx3.0-doc-3.0.1/debian/wx3.0-doc.linktrees 
> > > wx3.0-doc-3.0.1/debian/wx3.0-doc.linktrees
> > >>  --- wx3.0-doc-3.0.1/debian/wx3.0-doc.linktrees    1970-01-01 
> > > 01:00:00.000000000 +0100
> > >>  +++ wx3.0-doc-3.0.1/debian/wx3.0-doc.linktrees    2014-09-01 
> > > 15:34:21.000000000 +0200
> > >>  @@ -0,0 +1 @@
> > >>  +replace usr/share/javascript/jquery/jquery.js 
> > > usr/share/doc/wx3.0-doc/jquery.js
> > > 
> > > My understanding is that doxygen uses a patched version of jquery, so
> > > this replacement isn't correct.  I'm not sure what the recommended way
> > > to fix this is though.  There's some information here:
> > > 
> > > https://bugs.debian.org/736360
> > > 
> > 
> > I looked carefully at them, however I don't agree my solution is wrong.
> > 
> > Please look at the jquery 1.7.1 code
> > http://code.jquery.com/jquery-1.7.1.min.js
> > and meld with the jquery.js code inside
> > 
> > aside from 3 \r\n in the upstream minified code, it is the same file, no patches at all.
> > 
> > So I presume the debian jquery 1.7.2 will be just fine (I little tested it and it was fine aside from some little render bug, but I don't think it was jquery specific)
> > 
> > Your referred bug is when we _build_ the doxygen documentation, here we have the already built one, so we just need to copy-paste it.
> > 
> > Would be nice to force upstream to give the source doxygen documentation, but at least I think my solution is the best one (for the moment).
> > 
> > 
> > Please also look here [1]. If upstream starts providing doxygen documentation we will likely need to override the bug and fix doxygen instead.
> > 
> > [1] https://lists.debian.org/debian-mentors/2012/11/msg00313.html
> > 
> > Cheers,
> > 
> > 
> > Gianfranco
> > > Cheers,
> > > 
> > >     Olly
> > > 
> > > -- 
> > > To unsubscribe, send mail to 737050-unsubscribe at bugs.debian.org.
> > > 
> > 
> 
> -- 
> SUGIMOTO Norimitsu <dictoss at live.jp>
> 


-- 
SUGIMOTO Norimitsu <dictoss at live.jp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wxwidgets3.0-build-with-doc.debdiff
Type: application/octet-stream
Size: 6500 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/freewx-maint/attachments/20141026/0b317d22/attachment.obj>