[Freewx-maint] Bug#785924: wxwidgets3.0: Please update to GStreamer 1.x

[Sebastian Dröge]

Hi Olly,

On Do, 2015-05-21 at 01:24 +0100, Olly Betts wrote:

> But there's an upstream ticket about switching to gstreamer 1.0 with a
> recently added patch.  I'd appreciate a quick review from someone who
> has more idea about gstreamer's API than I do if you have a few minutes
> (it's not a huge patch):
> 
> http://trac.wxwidgets.org/attachment/ticket/14976/gst1.0.patch
> 
> I can tell the configure part needs improving, at least to make it
> upstream-able, which makes me wonder about its general quality.

wxGStreamerMediaBackend::QueryVideoSizeFromPad() probably leaks the caps
now, you need to unref() them after usage.

!gst_structure_has_name (gst_message_get_structure(message), "prepare-window-handle"))
should be using
gst_is_video_overlay_prepare_window_handle_message()



Otherwise seems ok if that is really enough to make things work. Not
sure if more changes are needed elsewhere.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/freewx-maint/attachments/20150521/5c43cf50/attachment.sig>