[Freewx-maint] Bug#786986: Wxwidgets webview link flags problem

[Gianfranco Costamagna]

Package: wxwidgets3.0
Version: 3.0.2-1
Severity: important

Tags: patch

As discussed in irc, wx-config actually has a wrong behaviour (Debian specific bug I guess)
this is causing autoconf to behave wrongly [1] when webview is not available.

Example (webview is *not* installed):

$ dpkg -s libwxgtk-webview3.0-dev

dpkg-query: package 'libwxgtk-webview3.0-dev' is not installed and no information is available

$ wx-config --libs webview
-L/usr/lib/x86_64-linux-gnu -pthread   -lwx_gtk2u_webview-3.0 -lwx_baseu-3.0 


this is returning webview flags, causing a build failure.

I don't know what should be the correct behaviour.

wx-config --libs webview,core,gtk
-L/usr/lib/x86_64-linux-gnu -pthread   -lwx_gtk2u_webview-3.0 -lwx_gtk2u_core-3.0 -lwx_gtk2u_gtk-3.0 -lwx_baseu-3.0 


when called with multiple libraries it can strip the webview (patching around line 1247 of wx-config), but this makes the build fail


the following patch seems to do the trick

-        # Only add base if --libs was specified and not just --optional-libs
-          if [ -n "$output_option_libs" ]; then
-                wx_libs="$wx_libs base"
+   if dpkg -s libwxgtk-webview3.0-dev > /dev/null 2>&1 ; then
+                # Only add base if --libs was specified and not just --optional-libs
+                if [ -n "$output_option_libs" ]; then
+                      wx_libs="$wx_libs base"
+     fi
+   else
+                exit 2


(attached the pach to apply directly on the debian patch)

I'm not sure if the patch is actually working on each corner case, but I'm submitting it anyway


thanks for considering it,

Cheers,

Gianfranco
[1] https://github.com/vslavik/poedit/issues/178
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: application/octet-stream
Size: 1441 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/freewx-maint/attachments/20150527/b25036a2/attachment.obj>