[helix-maintainers] Bug#330337: helix-player: FTBFS on most architectures

[Aaron M. Ucko]

Package: helix-player
Version: 1.0.5-1
Severity: important
Tags: patch
Justification: fails to build from source

The helix-player source package suffers from several small portability
bugs (most upstream's fault, I believe) that keep it from building
properly on most Debian architectures.  I have attached a patch that
addresses these just far enough to get it to build without errors on
amd64; however, certain fixes (such as setting SYSTEM_ID properly)
will need to be extended to the remaining architectures.  (I also
didn't bother encapsulating it as a dpatch, but that should be easy
enough to fix.)

BTW, you really ought to fix debian/rules clean to work from source
trees that *aren't* already pristine, per Policy 4.8.  As it is, a lot
of generated files are getting left behind; at best, this would bloat
the diff, but as it is, overwriting the top-level Makefile keeps
02_makefile.dpatch from being reversed, and the fact that many of
these files are binaries makes dpkg-source choke.  You may want to go
in for a setup where you copy the whole non-debian/ tree (or extract
it from a tarball) into a sandbox that the clean target can then
safely blow away in its entirety.

Thanks.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12.6
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages helix-player depends on:
ii  libatk1.0-0             1.10.3-1         The ATK accessibility toolkit
ii  libc6                   2.3.5-6          GNU C Library: Shared libraries an
ii  libgcc1                 1:4.0.1-9        GCC support library
ii  libglib2.0-0            2.8.1-1          The GLib library of C routines
ii  libgtk2.0-0             2.6.10-1         The GTK+ graphical user interface 
ii  libogg0                 1.1.2-1          Ogg Bitstream Library
ii  libpango1.0-0           1.8.2-2          Layout and rendering of internatio
ii  libstdc++6              4.0.1-9          The GNU Standard C++ Library v3
ii  libtheora0              0.0.0.alpha4-1.1 The Theora Video Compression Codec
ii  libvorbis0a             1.1.0-1          The Vorbis General Audio Compressi
ii  libx11-6                6.8.2.dfsg.1-7   X Window System protocol client li
ii  libxext6                6.8.2.dfsg.1-7   X Window System miscellaneous exte
ii  libxv1                  6.8.2.dfsg.1-7   X Window System video extension li
ii  xlibs                   6.8.2.dfsg.1-7   X Window System client libraries m

helix-player recommends no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amd64-fixes
Type: text/x-c++
Size: 5489 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/helix-maintainers/attachments/20051105/61380404/amd64-fixes.bin