[helix-maintainers] Bug#330337: marked as done (helix-player: FTBFS
on most architectures)
Debian Bug Tracking System
owner at bugs.debian.org
Sun Oct 23 14:03:49 UTC 2005
Your message dated Sun, 23 Oct 2005 06:43:36 -0700
with message-id <E1ETg8O-0004lo-00 at spohr.debian.org>
and subject line Bug#330337: fixed in helix-player 1.0.6-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 27 Sep 2005 16:12:02 +0000
>From ucko at debian.org Tue Sep 27 09:12:02 2005
Return-path: <ucko at debian.org>
Received: from smtp02.mrf.mail.rcn.net [207.172.4.62]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EKI3l-0007ge-00; Tue, 27 Sep 2005 09:12:01 -0700
Received: from 208-58-77-33.c3-0.grg-ubr3.lnh-grg.md.cable.rcn.com (HELO tux64.internal.ucko.debian.net) ([208.58.77.33])
by smtp02.mrf.mail.rcn.net with ESMTP; 27 Sep 2005 12:12:00 -0400
X-IronPort-AV: i="3.97,150,1125892800";
d="scan'208"; a="98692559:sNHT35773658"
Received: from amu by tux64.internal.ucko.debian.net with local (Exim 4.52)
id 1EKI3k-0002iV-28
for submit at bugs.debian.org; Tue, 27 Sep 2005 12:12:00 -0400
Content-Type: multipart/mixed; boundary="===============9168060942677132112=="
MIME-Version: 1.0
From: "Aaron M. Ucko" <ucko at debian.org>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Subject: helix-player: FTBFS on most architectures
X-Mailer: reportbug 3.17
Date: Tue, 27 Sep 2005 12:12:00 -0400
X-Debbugs-Cc: ucko at debian.org
Message-Id: <E1EKI3k-0002iV-28 at tux64.internal.ucko.debian.net>
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: ucko at debian.org
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-11.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
X_DEBBUGS_CC autolearn=ham version=2.60-bugs.debian.org_2005_01_02
This is a multi-part MIME message sent by reportbug.
--===============9168060942677132112==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: helix-player
Version: 1.0.5-1
Severity: important
Tags: patch
Justification: fails to build from source
The helix-player source package suffers from several small portability
bugs (most upstream's fault, I believe) that keep it from building
properly on most Debian architectures. I have attached a patch that
addresses these just far enough to get it to build without errors on
amd64; however, certain fixes (such as setting SYSTEM_ID properly)
will need to be extended to the remaining architectures. (I also
didn't bother encapsulating it as a dpatch, but that should be easy
enough to fix.)
BTW, you really ought to fix debian/rules clean to work from source
trees that *aren't* already pristine, per Policy 4.8. As it is, a lot
of generated files are getting left behind; at best, this would bloat
the diff, but as it is, overwriting the top-level Makefile keeps
02_makefile.dpatch from being reversed, and the fact that many of
these files are binaries makes dpkg-source choke. You may want to go
in for a setup where you copy the whole non-debian/ tree (or extract
it from a tarball) into a sandbox that the clean target can then
safely blow away in its entirety.
Thanks.
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12.6
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Versions of packages helix-player depends on:
ii libatk1.0-0 1.10.3-1 The ATK accessibility toolkit
ii libc6 2.3.5-6 GNU C Library: Shared libraries an
ii libgcc1 1:4.0.1-9 GCC support library
ii libglib2.0-0 2.8.1-1 The GLib library of C routines
ii libgtk2.0-0 2.6.10-1 The GTK+ graphical user interface
ii libogg0 1.1.2-1 Ogg Bitstream Library
ii libpango1.0-0 1.8.2-2 Layout and rendering of internatio
ii libstdc++6 4.0.1-9 The GNU Standard C++ Library v3
ii libtheora0 0.0.0.alpha4-1.1 The Theora Video Compression Codec
ii libvorbis0a 1.1.0-1 The Vorbis General Audio Compressi
ii libx11-6 6.8.2.dfsg.1-7 X Window System protocol client li
ii libxext6 6.8.2.dfsg.1-7 X Window System miscellaneous exte
ii libxv1 6.8.2.dfsg.1-7 X Window System video extension li
ii xlibs 6.8.2.dfsg.1-7 X Window System client libraries m
helix-player recommends no packages.
-- no debconf information
--===============9168060942677132112==
Content-Type: text/x-c++; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="amd64-fixes"
diff -u helix-player-1.0.5/debian/rules helix-player-1.0.5/debian/rules
--- helix-player-1.0.5/debian/rules
+++ helix-player-1.0.5/debian/rules
@@ -23,6 +23,10 @@
export BUILDRC:=$(shell pwd)/buildrc
export SYSTEM_ID:=linux-2.2-libc6-$(EXT)
+ifeq (amd64,$(ARCH))
+ export SYSTEM_ID:=linux-2.6-glibc23-amd64
+endif
+
build: build-stamp
build-stamp: patch
@echo "--- Compiling"
only in patch2:
unchanged:
--- helix-player-1.0.5.orig/datatype/ogg/fileformat/unix.pcf
+++ helix-player-1.0.5/datatype/ogg/fileformat/unix.pcf
@@ -1,3 +1,4 @@
-project.AddLibraries(os.path.join(GetSDKPath("oggvorbissdk"), "lib", "libogg.a"))
-project.AddLibraries(os.path.join(GetSDKPath("oggvorbissdk"), "lib", "libvorbis.a"))
+# project.AddLibraries(os.path.join(GetSDKPath("oggvorbissdk"), "lib", "libogg.a"))
+# project.AddLibraries(os.path.join(GetSDKPath("oggvorbissdk"), "lib", "libvorbis.a"))
+project.AddSystemLibraries("ogg", "vorbis")
only in patch2:
unchanged:
--- helix-player-1.0.5.orig/datatype/theora/renderer/linux2.pcf
+++ helix-player-1.0.5/datatype/theora/renderer/linux2.pcf
@@ -53,7 +53,7 @@
oggLibPath = os.path.join(GetSDKPath("oggvorbissdk"), "lib")
-project.AddLibraries(os.path.join(oggLibPath, "libogg.a"),
- os.path.join(oggLibPath, "libtheora.a"))
+#project.AddLibraries(os.path.join(oggLibPath, "libogg.a"),
+# os.path.join(oggLibPath, "libtheora.a"))
-project.AddSystemLibraries("pthread")
\ No newline at end of file
+project.AddSystemLibraries("pthread", "ogg", "theora")
only in patch2:
unchanged:
--- helix-player-1.0.5.orig/datatype/vorbis/renderer/unix.pcf
+++ helix-player-1.0.5/datatype/vorbis/renderer/unix.pcf
@@ -1,3 +1,4 @@
-project.AddLibraries(os.path.join(GetSDKPath("oggvorbissdk"), "lib", "libogg.a"))
-project.AddLibraries(os.path.join(GetSDKPath("oggvorbissdk"), "lib", "libvorbis.a"))
+# project.AddLibraries(os.path.join(GetSDKPath("oggvorbissdk"), "lib", "libogg.a"))
+# project.AddLibraries(os.path.join(GetSDKPath("oggvorbissdk"), "lib", "libvorbis.a"))
+project.AddSystemLibraries("ogg", "vorbis")
only in patch2:
unchanged:
--- helix-player-1.0.5.orig/audio/fixptutil/pub/math64.h
+++ helix-player-1.0.5/audio/fixptutil/pub/math64.h
@@ -124,7 +124,7 @@
// GCC / i386
///////////////////////////////////////////////////////////////////////////////////////
-#if defined(__GNUC__) && defined(__i386__) && !defined(_NO_GNU_AS)
+#if defined(__GNUC__) && (defined(__i386__) || defined(__amd64__)) && !defined(_NO_GNU_AS)
#define HAVE_PLATFORM_MACROS
@@ -199,7 +199,7 @@
#ifdef DEBUG
#define ASSERT(x) if (!(x)) __asm__ __volatile ("int $3" :: )
#endif
-#endif // defined(__GNUC__) && defined(__i386__)
+#endif // defined(__GNUC__) && defined(__i386__|__amd64__)
///////////////////////////////////////////////////////////////////////////////////////
// Sun native compiler / Sparc
only in patch2:
unchanged:
--- helix-player-1.0.5.orig/build/umakecf/linux-2.6-glibc23-amd64.cf
+++ helix-player-1.0.5/build/umakecf/linux-2.6-glibc23-amd64.cf
@@ -63,6 +63,6 @@
platform.cc.args["default"] = platform.cc.args["default"] + \
" -m64 -D__amd64__"
-project.RemoveSystemPaths("-L/usr/X11R6/lib")
-project.AddSystemPaths("-L/usr/X11R6/lib64")
+# project.RemoveSystemPaths("-L/usr/X11R6/lib")
+# project.AddSystemPaths("-L/usr/X11R6/lib64")
only in patch2:
unchanged:
--- helix-player-1.0.5.orig/common/import/gecko-sdk/nspr/include/prcpucfg.h
+++ helix-player-1.0.5/common/import/gecko-sdk/nspr/include/prcpucfg.h
@@ -182,6 +182,52 @@
#define PR_BYTES_PER_WORD_LOG2 3
#define PR_BYTES_PER_DWORD_LOG2 3
+#elif defined(__x86_64__)
+
+#define IS_LITTLE_ENDIAN 1
+#undef IS_BIG_ENDIAN
+#define IS_64
+
+#define PR_BYTES_PER_BYTE 1
+#define PR_BYTES_PER_SHORT 2
+#define PR_BYTES_PER_INT 4
+#define PR_BYTES_PER_INT64 8
+#define PR_BYTES_PER_LONG 8
+#define PR_BYTES_PER_FLOAT 4
+#define PR_BYTES_PER_DOUBLE 8
+#define PR_BYTES_PER_WORD 8
+#define PR_BYTES_PER_DWORD 8
+
+#define PR_BITS_PER_BYTE 8
+#define PR_BITS_PER_SHORT 16
+#define PR_BITS_PER_INT 32
+#define PR_BITS_PER_INT64 64
+#define PR_BITS_PER_LONG 64
+#define PR_BITS_PER_FLOAT 32
+#define PR_BITS_PER_DOUBLE 64
+#define PR_BITS_PER_WORD 64
+
+#define PR_BITS_PER_BYTE_LOG2 3
+#define PR_BITS_PER_SHORT_LOG2 4
+#define PR_BITS_PER_INT_LOG2 5
+#define PR_BITS_PER_INT64_LOG2 6
+#define PR_BITS_PER_LONG_LOG2 6
+#define PR_BITS_PER_FLOAT_LOG2 5
+#define PR_BITS_PER_DOUBLE_LOG2 6
+#define PR_BITS_PER_WORD_LOG2 6
+
+#define PR_ALIGN_OF_SHORT 2
+#define PR_ALIGN_OF_INT 4
+#define PR_ALIGN_OF_LONG 8
+#define PR_ALIGN_OF_INT64 8
+#define PR_ALIGN_OF_FLOAT 4
+#define PR_ALIGN_OF_DOUBLE 8
+#define PR_ALIGN_OF_POINTER 8
+#define PR_ALIGN_OF_WORD 8
+
+#define PR_BYTES_PER_WORD_LOG2 3
+#define PR_BYTES_PER_DWORD_LOG2 3
+
#elif defined(__mc68000__)
#undef IS_LITTLE_ENDIAN
only in patch2:
unchanged:
--- helix-player-1.0.5.orig/common/system/pub/platform/unix/pthreadthreads.h
+++ helix-player-1.0.5/common/system/pub/platform/unix/pthreadthreads.h
@@ -102,10 +102,15 @@
#ifndef _MAC_UNIX
+#ifdef __amd64__
+// sem_t is a union, and therefore can't be used as a base class.
+typedef sem_t HXsem_t;
+#else
struct HXsem_t : public sem_t
{
char padding[64]; /* Flawfinder: ignore */ // different linux versions have different binary reps blechhhh!
};
+#endif
//=======================================================================
//
--===============9168060942677132112==--
---------------------------------------
Received: (at 330337-close) by bugs.debian.org; 23 Oct 2005 13:48:19 +0000
>From joerg at spohr.debian.org Sun Oct 23 06:48:19 2005
Return-path: <joerg at spohr.debian.org>
Received: from joerg by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1ETg8O-0004lo-00; Sun, 23 Oct 2005 06:43:36 -0700
From: Daniel Baumann <daniel.baumann at panthera-systems.net>
To: 330337-close at bugs.debian.org
X-Katie: lisa $Revision: 1.30 $
Subject: Bug#330337: fixed in helix-player 1.0.6-2
Message-Id: <E1ETg8O-0004lo-00 at spohr.debian.org>
Sender: Joerg Jaspert <joerg at spohr.debian.org>
Date: Sun, 23 Oct 2005 06:43:36 -0700
Delivered-To: 330337-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 6
Source: helix-player
Source-Version: 1.0.6-2
We believe that the bug you reported is fixed in the latest version of
helix-player, which is due to be installed in the Debian FTP archive:
helix-player_1.0.6-2.diff.gz
to pool/main/h/helix-player/helix-player_1.0.6-2.diff.gz
helix-player_1.0.6-2.dsc
to pool/main/h/helix-player/helix-player_1.0.6-2.dsc
helix-player_1.0.6-2_i386.deb
to pool/main/h/helix-player/helix-player_1.0.6-2_i386.deb
mozilla-helix-player_1.0.6-2_i386.deb
to pool/main/h/helix-player/mozilla-helix-player_1.0.6-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 330337 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <daniel.baumann at panthera-systems.net> (supplier of updated helix-player package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 2 Oct 2005 11:32:00 +0200
Source: helix-player
Binary: mozilla-helix-player helix-player
Architecture: source i386
Version: 1.0.6-2
Distribution: unstable
Urgency: high
Maintainer: Daniel Baumann <daniel.baumann at panthera-systems.net>
Changed-By: Daniel Baumann <daniel.baumann at panthera-systems.net>
Description:
helix-player - the helix audio and video player
mozilla-helix-player - the helix audio and video player (browser plugin)
Closes: 309121 314049 316364 316366 327483 330337 330876
Changes:
helix-player (1.0.6-2) unstable; urgency=high
.
* Redone debian/:
- simplified build-depends.
- set architecture manually.
- moved browser-plugins into separate mozilla-helix-player package.
- corrected copyright file, we do distribute helix-player under the GPL.
- rebuild patches.
- added patch to fix typo in German locale (Closes: #314049).
- added patch to fix bugs on amd64 (Closes: #330337, #309121).
- rewritten maintainer-scripts (Closes: #316364, #327483, #330876).
- rewritten postbuild-script (Closes: #316366).
Files:
025ae996cd0322eb4ee675b6fc80c1a7 891 graphics optional helix-player_1.0.6-2.dsc
91a1283b6df05c63943d2a67f3acf469 8927 graphics optional helix-player_1.0.6-2.diff.gz
33e1d23e5d4b64da963fe1eada2c2287 4088894 graphics optional helix-player_1.0.6-2_i386.deb
cc1876efe71e42f83e38a8b2ec586226 47984 web optional mozilla-helix-player_1.0.6-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDUrMIxa93SlhRC1oRAuE0AKCfesZGmXcxwy8rC+DH43Mfi/Cc4wCdGyIJ
YULtgIyyVi/YeSo/neaCG0U=
=aAa2
-----END PGP SIGNATURE-----
More information about the helix-maintainers
mailing list