[Initscripts-ng-commits] r774 - in /branches/insserv-1.11.9/debian/patches: 11_more_warnings.patch 42_loopnochangemsg.patch 62_warn_on_missing_required_fields.patch 63_warn_on_missing_default_fields.patch 64_missing_default_fields_fallback.patch 70_test_suite_failed_count.patch

Mon Jul 14 04:26:48 UTC 2008

Author: kelmo-guest
Date: Mon Jul 14 04:26:48 2008
New Revision: 774

URL: http://svn.debian.org/wsvn/initscripts-ng/?sc=1&rev=774
Log:
Add patch descriptions for submission.

Modified:
    branches/insserv-1.11.9/debian/patches/11_more_warnings.patch
    branches/insserv-1.11.9/debian/patches/42_loopnochangemsg.patch
    branches/insserv-1.11.9/debian/patches/62_warn_on_missing_required_fields.patch
    branches/insserv-1.11.9/debian/patches/63_warn_on_missing_default_fields.patch
    branches/insserv-1.11.9/debian/patches/64_missing_default_fields_fallback.patch
    branches/insserv-1.11.9/debian/patches/70_test_suite_failed_count.patch

Modified: branches/insserv-1.11.9/debian/patches/11_more_warnings.patch
URL: http://svn.debian.org/wsvn/initscripts-ng/branches/insserv-1.11.9/debian/patches/11_more_warnings.patch?rev=774&op=diff
==============================================================================

--- branches/insserv-1.11.9/debian/patches/11_more_warnings.patch (original)
+++ branches/insserv-1.11.9/debian/patches/11_more_warnings.patch Mon Jul 14 04:26:48 2008
@@ -1,7 +1,4 @@
-Goal:                Make more issues visible by using -W in addition to -Wall
-Fixes:               none
-Status wrt upstream: Need to submit upstream
-Notes:               none
+Make more issues visible by using -W in addition to -Wall
 ---
 --- a/Makefile
 +++ b/Makefile

Modified: branches/insserv-1.11.9/debian/patches/42_loopnochangemsg.patch
URL: http://svn.debian.org/wsvn/initscripts-ng/branches/insserv-1.11.9/debian/patches/42_loopnochangemsg.patch?rev=774&op=diff
==============================================================================
--- branches/insserv-1.11.9/debian/patches/42_loopnochangemsg.patch (original)
+++ branches/insserv-1.11.9/debian/patches/42_loopnochangemsg.patch Mon Jul 14 04:26:48 2008
@@ -1,3 +1,6 @@
+When a loop is detected, inform the user that no runlevel link changes
+are made before bailing out.
+---
 --- a/insserv.c
 +++ b/insserv.c
 @@ -2960,7 +2960,7 @@

Modified: branches/insserv-1.11.9/debian/patches/62_warn_on_missing_required_fields.patch
URL: http://svn.debian.org/wsvn/initscripts-ng/branches/insserv-1.11.9/debian/patches/62_warn_on_missing_required_fields.patch?rev=774&op=diff
==============================================================================
--- branches/insserv-1.11.9/debian/patches/62_warn_on_missing_required_fields.patch (original)
+++ branches/insserv-1.11.9/debian/patches/62_warn_on_missing_required_fields.patch Mon Jul 14 04:26:48 2008
@@ -1,3 +1,8 @@
+If any of the required LSB init info fields are absent from script, make noise
+in default output level of insserv. This will assist in package maintainers
+and upstream developers becoming aware that they need to conform to LSB
+initscript spec at least with basic fields.
+---
 --- a/insserv.c
 +++ b/insserv.c
 @@ -1292,7 +1292,7 @@

Modified: branches/insserv-1.11.9/debian/patches/63_warn_on_missing_default_fields.patch
URL: http://svn.debian.org/wsvn/initscripts-ng/branches/insserv-1.11.9/debian/patches/63_warn_on_missing_default_fields.patch?rev=774&op=diff
==============================================================================
--- branches/insserv-1.11.9/debian/patches/63_warn_on_missing_default_fields.patch (original)
+++ branches/insserv-1.11.9/debian/patches/63_warn_on_missing_default_fields.patch Mon Jul 14 04:26:48 2008
@@ -1,3 +1,6 @@
+Also warn when Default-Start and Default-Stop (!SUSE) fields are not present in
+LSB init info. They are required even when empty.
+---
 --- a/insserv.c
 +++ b/insserv.c
 @@ -1292,7 +1292,12 @@

Modified: branches/insserv-1.11.9/debian/patches/64_missing_default_fields_fallback.patch
URL: http://svn.debian.org/wsvn/initscripts-ng/branches/insserv-1.11.9/debian/patches/64_missing_default_fields_fallback.patch?rev=774&op=diff
==============================================================================
--- branches/insserv-1.11.9/debian/patches/64_missing_default_fields_fallback.patch (original)
+++ branches/insserv-1.11.9/debian/patches/64_missing_default_fields_fallback.patch Mon Jul 14 04:26:48 2008
@@ -1,3 +1,11 @@
+In Debian, if Default-Start or Default-Stop fields are empty in script LSB init
+info header, do not fallback to defaults, instead print a warning and create no
+links at all.
+
+This should not happen at all, as /usr/sbin/update-rc.d and lintian should be
+able to print enough warnings so that a package maintainer notices problem
+during his/her package quality control tests.
+---
 --- a/insserv.c
 +++ b/insserv.c
 @@ -2796,8 +2796,10 @@

Modified: branches/insserv-1.11.9/debian/patches/70_test_suite_failed_count.patch
URL: http://svn.debian.org/wsvn/initscripts-ng/branches/insserv-1.11.9/debian/patches/70_test_suite_failed_count.patch?rev=774&op=diff
==============================================================================
--- branches/insserv-1.11.9/debian/patches/70_test_suite_failed_count.patch (original)
+++ branches/insserv-1.11.9/debian/patches/70_test_suite_failed_count.patch Mon Jul 14 04:26:48 2008
@@ -1,3 +1,6 @@
+Count test failures and print out more detail stats in finish_test function of
+common test suite shlib.
+---
 --- a/tests/suite
 +++ b/tests/suite
 @@ -15,12 +15,15 @@


