[Initscripts-ng-commits] r795 - in /branches/insserv-1.11.10/debian: changelog run-testsuite

[kelmo-guest at users.alioth.debian.org]

Author: kelmo-guest
Date: Tue Jul 22 16:19:07 2008
New Revision: 795

URL: http://svn.debian.org/wsvn/initscripts-ng/?sc=1&rev=795
Log:
Make test_newbug_keepoldorder() test case non-fatal, the fact that it
passed before was not by design but by luck, as per upstream analysis
which is included with test code.

Modified:
    branches/insserv-1.11.10/debian/changelog
    branches/insserv-1.11.10/debian/run-testsuite

Modified: branches/insserv-1.11.10/debian/changelog
URL: http://svn.debian.org/wsvn/initscripts-ng/branches/insserv-1.11.10/debian/changelog?rev=795&op=diff
==============================================================================
--- branches/insserv-1.11.10/debian/changelog (original)
+++ branches/insserv-1.11.10/debian/changelog Tue Jul 22 16:19:07 2008
@@ -42,8 +42,11 @@
   * Make test_adding_start() case a more realistic example.
   * Make test_incorrect_stopscripts() a fatal test, insserv should not
     add shutdown links when none are present.
-
- -- Kel Modderman <kel at otaku42.de>  Wed, 23 Jul 2008 02:02:18 +1000
+  * Make test_newbug_keepoldorder() test case non-fatal, the fact that it
+    passed before was not by design but by luck, as per upstream analysis
+    which is included with test code.
+
+ -- Kel Modderman <kel at otaku42.de>  Wed, 23 Jul 2008 02:15:27 +1000
 
 insserv (1.11.0-9) unstable; urgency=low
 

Modified: branches/insserv-1.11.10/debian/run-testsuite
URL: http://svn.debian.org/wsvn/initscripts-ng/branches/insserv-1.11.10/debian/run-testsuite?rev=795&op=diff
==============================================================================
--- branches/insserv-1.11.10/debian/run-testsuite (original)
+++ branches/insserv-1.11.10/debian/run-testsuite Tue Jul 22 16:19:07 2008
@@ -888,12 +888,31 @@
 
 list_rclinks
 
-check_order S mountall needlocal
-check_order S mountall needremote
-check_order S mountall needboth
-check_order S needlocal needremote
-check_order S needlocal needboth
-check_order S needremote needboth
+# The severity of this test should be fatal, below is explanation about how
+# new (1.11.10) and old (1.11.0) insserv version behaviour changed in this
+# test.
+#
+# Hmm ... with this I've found out that the old insserv will
+# run on a loop and therefore exit.  This loop was caused
+# by the system facility $local_fs make the old insserv
+# to do an exit ... now the problem is that the new insserv
+# expands all system facility to their real requirements.
+# This leads to the new behaviour as there is no node during
+# the sorting algorithm which would cause such a loop.
+#
+# In other words: that the old insserv hasn't changed the
+# order was simply a side effect of having a ghost node
+# whereas the new insserv does not use such nodes anymore.
+#
+# If you would remove the `X-Start-Before: $local_fs' the
+# old insserv will also change the boot order.
+
+${severity}_order S mountall needlocal
+${severity}_order S mountall needremote
+${severity}_order S mountall needboth
+${severity}_order S needlocal needremote
+${severity}_order S needlocal needboth
+${severity}_order S needremote needboth
 }
 ##########################################################################
 test_start_before() {
@@ -1433,7 +1452,7 @@
 test_removal
 test_segfault_virtfac
 test_incorrect_stopscripts
-test_newbug_keepoldorder	# 3 rc tests failing
+test_newbug_keepoldorder	# 3 non-fatal tests failing
 test_start_before
 test_stop_after
 test_adding_start