[Initscripts-ng-commits] r746 - in /trunk/src/insserv/debian: changelog patches/00list patches/62_warn_on_missing_required_fields.dpatch patches/63_warn_on_missing_default_fields.dpatch
kelmo-guest at users.alioth.debian.org
kelmo-guest at users.alioth.debian.org
Mon May 19 13:53:59 UTC 2008
Author: kelmo-guest
Date: Mon May 19 13:53:58 2008
New Revision: 746
URL: http://svn.debian.org/wsvn/initscripts-ng/?sc=1&rev=746
Log:
Add 62_warn_on_missing_required_fields and
63_warn_on_missing_default_fields to enable warnings by default about
missing Provides, Required-Start, Required-Stop, Default-Start or
Default-Stop LSB comment keywords.
Added:
trunk/src/insserv/debian/patches/62_warn_on_missing_required_fields.dpatch (with props)
trunk/src/insserv/debian/patches/63_warn_on_missing_default_fields.dpatch (with props)
Modified:
trunk/src/insserv/debian/changelog
trunk/src/insserv/debian/patches/00list
Modified: trunk/src/insserv/debian/changelog
URL: http://svn.debian.org/wsvn/initscripts-ng/trunk/src/insserv/debian/changelog?rev=746&op=diff
==============================================================================
--- trunk/src/insserv/debian/changelog (original)
+++ trunk/src/insserv/debian/changelog Mon May 19 13:53:58 2008
@@ -34,8 +34,12 @@
missing Default-Stop field, and that links are created in stop runlevels.
* Add to header of 61_default_stop_changed_from_empty.dpatch Goal, Fixes and
Status headings as per good patch policy.
-
- -- Kel Modderman <kel at otaku42.de> Mon, 19 May 2008 22:23:58 +1000
+ * Add 62_warn_on_missing_required_fields and
+ 63_warn_on_missing_default_fields to enable warnings by default about
+ missing Provides, Required-Start, Required-Stop, Default-Start or
+ Default-Stop LSB comment keywords.
+
+ -- Kel Modderman <kel at otaku42.de> Mon, 19 May 2008 23:52:35 +1000
insserv (1.11.0-8) unstable; urgency=low
Modified: trunk/src/insserv/debian/patches/00list
URL: http://svn.debian.org/wsvn/initscripts-ng/trunk/src/insserv/debian/patches/00list?rev=746&op=diff
==============================================================================
--- trunk/src/insserv/debian/patches/00list (original)
+++ trunk/src/insserv/debian/patches/00list Mon May 19 13:53:58 2008
@@ -11,3 +11,5 @@
52_shutdown_links
60_disable_cfgfilter_stat
61_default_stop_changed_from_empty
+62_warn_on_missing_required_fields
+63_warn_on_missing_default_fields
Added: trunk/src/insserv/debian/patches/62_warn_on_missing_required_fields.dpatch
URL: http://svn.debian.org/wsvn/initscripts-ng/trunk/src/insserv/debian/patches/62_warn_on_missing_required_fields.dpatch?rev=746&op=file
==============================================================================
--- trunk/src/insserv/debian/patches/62_warn_on_missing_required_fields.dpatch (added)
+++ trunk/src/insserv/debian/patches/62_warn_on_missing_required_fields.dpatch Mon May 19 13:53:58 2008
@@ -1,0 +1,28 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 62_warn_on_missing_required_fields.dpatch by Kel Modderman <kel at otaku42.de>
+##
+## DP: Goal: Emit warning when script contains header with missing Provides,
+## DP: Required-Start or Required-Stop LSB comment keywords. This is
+## DP: consistent with lintian warning:
+## DP: http://lintian.debian.org/reports/tags/init.d-script-missing-lsb-keyword.html
+## DP:
+## DP: Fixes: none
+## DP:
+## DP: Status: Intend to submit upstream.
+
+ at DPATCH@
+diff -urNad insserv~/insserv.c insserv/insserv.c
+--- insserv~/insserv.c 2008-05-19 23:36:39.000000000 +1000
++++ insserv/insserv.c 2008-05-19 23:38:11.214013731 +1000
+@@ -1257,9 +1257,9 @@
+ }
+
+ #ifndef USE_STOP_TAGS
+- if (verbose && (begin && end && (!provides || !required_start)))
++ if (begin && end && (!provides || !required_start))
+ #else /* USE_STOP_TAGS */
+- if (verbose && (begin && end && (!provides || !required_start || !required_stop)))
++ if (begin && end && (!provides || !required_start || !required_stop))
+ #endif /* USE_STOP_TAGS */
+ {
+ char *name = basename(path);
Propchange: trunk/src/insserv/debian/patches/62_warn_on_missing_required_fields.dpatch
------------------------------------------------------------------------------
svn:executable = *
Added: trunk/src/insserv/debian/patches/63_warn_on_missing_default_fields.dpatch
URL: http://svn.debian.org/wsvn/initscripts-ng/trunk/src/insserv/debian/patches/63_warn_on_missing_default_fields.dpatch?rev=746&op=file
==============================================================================
--- trunk/src/insserv/debian/patches/63_warn_on_missing_default_fields.dpatch (added)
+++ trunk/src/insserv/debian/patches/63_warn_on_missing_default_fields.dpatch Mon May 19 13:53:58 2008
@@ -1,0 +1,43 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 63_warn_on_missing_default_fields.dpatch by Kel Modderman <kel at otaku42.de>
+##
+## DP: Goal: Emit warning when script contains header with missing
+## DP: Default-Start or Default-Stop LSB comment keywords in addition to
+## DP: Provides, Required-Start and Required-Stop. This is consistent with
+## DP: lintian warning:
+## DP: http://lintian.debian.org/reports/tags/init.d-script-missing-lsb-keyword.html
+## DP:
+## DP: Fixes: none
+## DP:
+## DP: Status: Intend to submit upstream.
+
+ at DPATCH@
+diff -urNad insserv~/insserv.c insserv/insserv.c
+--- insserv~/insserv.c 2008-05-19 23:41:03.000000000 +1000
++++ insserv/insserv.c 2008-05-19 23:44:16.094012864 +1000
+@@ -1257,9 +1257,9 @@
+ }
+
+ #ifndef USE_STOP_TAGS
+- if (begin && end && (!provides || !required_start))
++ if (begin && end && (!provides || !required_start || !default_start))
+ #else /* USE_STOP_TAGS */
+- if (begin && end && (!provides || !required_start || !required_stop))
++ if (begin && end && (!provides || !required_start || !required_stop || !default_start || !default_stop))
+ #endif /* USE_STOP_TAGS */
+ {
+ char *name = basename(path);
+@@ -1270,9 +1270,13 @@
+ warn("Missing entry for Provides: please add even if empty.\n");
+ if (!required_start)
+ warn("Missing entry for Required-Start: please add even if empty.\n");
++ if (!default_start)
++ warn("Missing entry for Default-Start: please add even if empty.\n");
+ #ifdef USE_STOP_TAGS
+ if (!required_stop)
+ warn("Missing entry for Required-Stop: please add even if empty.\n");
++ if (!default_stop)
++ warn("Missing entry for Default-Stop: please add even if empty.\n");
+ #endif /* USE_STOP_TAGS */
+ }
+
Propchange: trunk/src/insserv/debian/patches/63_warn_on_missing_default_fields.dpatch
------------------------------------------------------------------------------
svn:executable = *
More information about the Initscripts-ng-commits
mailing list