r1289 - in trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian: . patches

[Dann Frazier]

Author: dannf
Date: 2004-08-24 02:54:47 -0600 (Tue, 24 Aug 2004)
New Revision: 1289

Added:
   trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/patches/drivers-scsi-sym_2-dv-hang.dpatch
Modified:
   trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/changelog
   trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/patches/00list-3
Log:
replace the workaround for the sym hang i was seeing on my HP i2000 w/
a proper fix from James Bottomley


Modified: trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/changelog
===================================================================
--- trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/changelog	2004-08-24 08:51:58 UTC (rev 1288)
+++ trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/changelog	2004-08-24 08:54:47 UTC (rev 1289)
@@ -17,6 +17,10 @@
 
   * Add qdisc crash fix (closes: #266892) (Christoph Hellwig).
 
+  * Replace the drivers-scsi-sym53c8xx_revert workaround with 
+    drivers-scsi-sym_2-dv-hang, which is a proper fix for the hang
+    (dann frazier).
+
  -- Andres Salomon <dilinger@voxel.net>  Wed, 18 Aug 2004 02:13:56 -0400
 
 kernel-source-2.6.8 (2.6.8-2) unstable; urgency=high

Modified: trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/patches/00list-3
===================================================================
--- trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/patches/00list-3	2004-08-24 08:51:58 UTC (rev 1288)
+++ trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/patches/00list-3	2004-08-24 08:54:47 UTC (rev 1289)
@@ -28,7 +28,6 @@
 ptmx-fix
 powerpc-ibm-240-e30
 xfs-ioctl32
-drivers-scsi-sym53c8xx_revert
 ia64-generic-no-smp-1-to-2
 ia64_cyclone_nosmp
 fix-sn_console-for-config_smp
@@ -37,3 +36,4 @@
 acpi-osname
 pmac-no-of-stdout
 net-sched-fix
+drivers-scsi-sym_2-dv-hang

Added: trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/patches/drivers-scsi-sym_2-dv-hang.dpatch
===================================================================
--- trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/patches/drivers-scsi-sym_2-dv-hang.dpatch	2004-08-24 08:51:58 UTC (rev 1288)
+++ trunk/kernel/source/kernel-source-2.6.8-2.6.8/debian/patches/drivers-scsi-sym_2-dv-hang.dpatch	2004-08-24 08:54:47 UTC (rev 1289)
@@ -0,0 +1,42 @@
+#! /bin/sh -e 
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Description: Fix DV hang with certain devices
+## DP: Patch author: James Bottomley
+## DP: Upstream status: Submitted
+
+. $(dirname $0)/DPATCH
+
+@DPATCH@
+There's a bad hang where the driver locks the system solid trying to do
+domain validation with certain devices.  The one I've managed to
+reproduce it with is a Quantum Atlas.
+
+What happens is that setting the offset to zero is an async negotiation
+message.  However, the driver still seems to have DT set (which is
+illegal).  Most devices just reject this as stupid, but the Quantum
+seems to try to obey it and hangs the bus.
+
+The simple fix is to reset all PPR options when the offset is set to
+zero.
+
+James
+
+===== drivers/scsi/sym53c8xx_2/sym_glue.c 1.44 vs edited =====
+--- 1.44/drivers/scsi/sym53c8xx_2/sym_glue.c	2004-07-26 17:24:36 -04:00
++++ edited/drivers/scsi/sym53c8xx_2/sym_glue.c	2004-08-19 22:30:35 -04:00
+@@ -2383,6 +2383,9 @@
+ 	struct sym_hcb *np = ((struct host_data *)sdev->host->hostdata)->ncb;
+ 	struct sym_tcb *tp = &np->target[sdev->id];
+ 
++	if (offset == 0)
++		tp->tinfo.goal.options = 0;
++
+ 	if (tp->tinfo.curr.options & PPR_OPT_DT) {
+ 		if (offset > np->maxoffs_dt)
+ 			offset = np->maxoffs_dt;
+
+-
+To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
+the body of a message to majordomo@vger.kernel.org
+More majordomo info at  http://vger.kernel.org/majordomo-info.html